rmm: [BUG] RMM spits pages of deprecated warnings when building
Describe the bug and steps to reproduce
mkdir build && cd build
cmake .. # options
make -j
outputs pages of deprecated warnings due to the use of [[deprecated]] APIs in tests.
I can reproduce this with clang and gcc.
Expected behavior
The current development branch builds without warnings. Otherwise I need to skim through pages of warnings every time I make a change to verify that I haven’t introduced any new issues, which costs me time.
Environment details (please complete the following information):
- Environment location: docker
- Method of RMM install: source
- Docker: custom image, no docker pull provided.
Other
Possible fix: always test simple build without dependencies on CI, using -Werror to prevent this issue from being re-introduced in the future.
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 15 (15 by maintainers)
In 0.14 it was not yet deprecated. In 0.15 it is deprecated. Since RMM follows SEMVER and is pre-1.0 software I think it’s reasonable to remove in 0.16.
No worries, I also realized the reason I don’t see all the warnings: I, like a lot of the RAPIDS team, use rapids-compose for development (https://github.com/trxcllnt/rapids-compose/), which has a lot of convenience features designed for our process, and I just noticed that it disables the deprecation warnings. Sorry about that.
Try this 😉: