node-lz4: 0.6.4 package seems to be missing parts?

After trying out the 0.6.4 version (see https://github.com/pierrec/node-lz4/pull/98#issuecomment-650049700) I receive errors:

> lz4@0.6.4 install /home/andreas/project/collaborne-event-stream-library/node_modules/lz4
> node-gyp rebuild

make: Entering directory '[...]/node_modules/lz4/build'
  CXX(target) Release/obj.target/lz4/lib/binding/lz4_binding.o
../lib/binding/lz4_binding.cc:8:10: fatal error: ../../deps/lz4/lib/lz4.h: No such file or directory
    8 | #include "../../deps/lz4/lib/lz4.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [lz4.target.mk:118: Release/obj.target/lz4/lib/binding/lz4_binding.o] Error 1
make: Leaving directory '[...]/node_modules/lz4/build'

Comparing the package contents it seems things are missing?

--- 0.6.3	2020-06-26 12:39:25.353723918 +0200
+++ 0.6.4	2020-06-26 12:39:27.999743756 +0200
@@ -2,140 +2,9 @@
 package/binding.gyp
 package/bin/lz4c
 package/bower.json
-package/build/binding.Makefile
 package/build/lz4.js
 package/build/lz4.min.js
-package/build/lz4.target.mk
-package/build/Makefile
-package/build/Release/.deps/Release/lz4.node.d
-package/build/Release/.deps/Release/obj.target/lz4/deps/lz4/lib/lz4hc.o.d
-package/build/Release/.deps/Release/obj.target/lz4/deps/lz4/lib/lz4.o.d
-package/build/Release/.deps/Release/obj.target/lz4/lib/binding/lz4_binding.o.d
-package/build/Release/.deps/Release/obj.target/lz4.node.d
-package/build/Release/.deps/Release/obj.target/xxhash/deps/lz4/lib/xxhash.o.d
-package/build/Release/.deps/Release/obj.target/xxhash/lib/binding/xxhash_binding.o.d
-package/build/Release/.deps/Release/obj.target/xxhash.node.d
-package/build/Release/.deps/Release/xxhash.node.d
-package/build/Release/lz4.node
-package/build/Release/obj.target/lz4/deps/lz4/lib/lz4hc.o
-package/build/Release/obj.target/lz4/deps/lz4/lib/lz4.o
-package/build/Release/obj.target/lz4/lib/binding/lz4_binding.o
-package/build/Release/obj.target/lz4.node
-package/build/Release/obj.target/xxhash/deps/lz4/lib/xxhash.o
-package/build/Release/obj.target/xxhash/lib/binding/xxhash_binding.o
-package/build/Release/obj.target/xxhash.node
-package/build/Release/xxhash.node
 package/build.sh
-package/build/xxhash.target.mk
-package/deps/lz4/appveyor.yml
-package/deps/lz4/circle.yml
-package/deps/lz4/contrib/cmake_unofficial/CMakeLists.txt
-package/deps/lz4/contrib/debian/changelog
-package/deps/lz4/contrib/debian/compat
-package/deps/lz4/contrib/debian/control
-package/deps/lz4/contrib/debian/copyright
-package/deps/lz4/contrib/debian/dirs
-package/deps/lz4/contrib/debian/docs
-package/deps/lz4/contrib/debian/liblz4-dev.install
-package/deps/lz4/contrib/debian/liblz4.install
-package/deps/lz4/contrib/debian/rules
-package/deps/lz4/contrib/djgpp/LICENSE
-package/deps/lz4/contrib/djgpp/Makefile
-package/deps/lz4/contrib/djgpp/README.MD
-package/deps/lz4/contrib/gen_manual/gen-lz4-manual.sh
-package/deps/lz4/contrib/gen_manual/gen_manual.cpp
-package/deps/lz4/contrib/gen_manual/Makefile
-package/deps/lz4/contrib/gen_manual/README.md
-package/deps/lz4/doc/images/usingCDict_1_8_2.png
-package/deps/lz4/doc/lz4_Block_format.md
-package/deps/lz4/doc/lz4_Frame_format.md
-package/deps/lz4/doc/lz4frame_manual.html
-package/deps/lz4/doc/lz4_manual.html
-package/deps/lz4/examples/blockStreaming_doubleBuffer.c
-package/deps/lz4/examples/blockStreaming_doubleBuffer.md
-package/deps/lz4/examples/blockStreaming_lineByLine.c
-package/deps/lz4/examples/blockStreaming_lineByLine.md
-package/deps/lz4/examples/blockStreaming_ringBuffer.c
-package/deps/lz4/examples/compress_functions.c
-package/deps/lz4/examples/COPYING
-package/deps/lz4/examples/dictionaryRandomAccess.c
-package/deps/lz4/examples/dictionaryRandomAccess.md
-package/deps/lz4/examples/frameCompress.c
-package/deps/lz4/examples/HCStreaming_ringBuffer.c
-package/deps/lz4/examples/Makefile
-package/deps/lz4/examples/printVersion.c
-package/deps/lz4/examples/README.md
-package/deps/lz4/examples/simple_buffer.c
-package/deps/lz4/examples/streaming_api_basics.md
-package/deps/lz4/.gitattributes
-package/deps/lz4/INSTALL
-package/deps/lz4/lib/dll/example/fullbench-dll.sln
-package/deps/lz4/lib/dll/example/fullbench-dll.vcxproj
-package/deps/lz4/lib/dll/example/Makefile
-package/deps/lz4/lib/dll/example/README.md
-package/deps/lz4/lib/dll/liblz4.def
-package/deps/lz4/lib/liblz4.pc.in
-package/deps/lz4/lib/LICENSE
-package/deps/lz4/lib/lz4.c
-package/deps/lz4/lib/lz4frame.c
-package/deps/lz4/lib/lz4frame.h
-package/deps/lz4/lib/lz4frame_static.h
-package/deps/lz4/lib/lz4.h
-package/deps/lz4/lib/lz4hc.c
-package/deps/lz4/lib/lz4hc.h
-package/deps/lz4/lib/Makefile
-package/deps/lz4/lib/README.md
-package/deps/lz4/lib/xxhash.c
-package/deps/lz4/lib/xxhash.h
-package/deps/lz4/LICENSE
-package/deps/lz4/Makefile
-package/deps/lz4/NEWS
-package/deps/lz4/programs/bench.c
-package/deps/lz4/programs/bench.h
-package/deps/lz4/programs/COPYING
-package/deps/lz4/programs/datagen.c
-package/deps/lz4/programs/datagen.h
-package/deps/lz4/programs/lz4.1
-package/deps/lz4/programs/lz4.1.md
-package/deps/lz4/programs/lz4cli.c
-package/deps/lz4/programs/lz4io.c
-package/deps/lz4/programs/lz4io.h
-package/deps/lz4/programs/Makefile
-package/deps/lz4/programs/platform.h
-package/deps/lz4/programs/README.md
-package/deps/lz4/programs/util.h
-package/deps/lz4/README.md
-package/deps/lz4/tests/checkTag.c
-package/deps/lz4/tests/COPYING
-package/deps/lz4/tests/datagencli.c
-package/deps/lz4/tests/frametest.c
-package/deps/lz4/tests/fullbench.c
-package/deps/lz4/tests/fuzzer.c
-package/deps/lz4/tests/Makefile
-package/deps/lz4/tests/README.md
-package/deps/lz4/tests/test_install.sh
-package/deps/lz4/tests/test-lz4-speed.py
-package/deps/lz4/tests/test-lz4-versions.py
-package/deps/lz4/.travis.yml
-package/deps/lz4/visual/README.md
-package/deps/lz4/visual/VS2010/datagen/datagen.vcxproj
-package/deps/lz4/visual/VS2010/frametest/frametest.vcxproj
-package/deps/lz4/visual/VS2010/fullbench-dll/fullbench-dll.vcxproj
-package/deps/lz4/visual/VS2010/fullbench/fullbench.vcxproj
-package/deps/lz4/visual/VS2010/fuzzer/fuzzer.vcxproj
-package/deps/lz4/visual/VS2010/liblz4-dll/liblz4-dll.rc
-package/deps/lz4/visual/VS2010/liblz4-dll/liblz4-dll.vcxproj
-package/deps/lz4/visual/VS2010/liblz4/liblz4.vcxproj
-package/deps/lz4/visual/VS2010/lz4.sln
-package/deps/lz4/visual/VS2017/datagen/datagen.vcxproj
-package/deps/lz4/visual/VS2017/frametest/frametest.vcxproj
-package/deps/lz4/visual/VS2017/fullbench-dll/fullbench-dll.vcxproj
-package/deps/lz4/visual/VS2017/fullbench/fullbench.vcxproj
-package/deps/lz4/visual/VS2017/fuzzer/fuzzer.vcxproj
-package/deps/lz4/visual/VS2017/liblz4-dll/liblz4-dll.rc
-package/deps/lz4/visual/VS2017/liblz4-dll/liblz4-dll.vcxproj
-package/deps/lz4/visual/VS2017/liblz4/liblz4.vcxproj
-package/deps/lz4/visual/VS2017/lz4.sln
 package/doc/format.txt
 package/examples/compress.html
 package/examples/cu.html
@@ -161,11 +30,11 @@
 package/lib/encoder.js
 package/lib/encoder_stream.js
 package/lib/lz4.js
+package/lib/lz4l.js
 package/lib/static.js
 package/lib/utils.js
 package/lib/utils-js.js
 package/LICENSE
-package/.npmignore
 package/package.json
 package/README.md
 package/test/block-test.js

Work-around: Pin the dependency of lz4 to 0.6.3 in package.json.

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Reactions: 25
  • Comments: 20 (4 by maintainers)

Commits related to this issue

Most upvoted comments

I have updated dependencies in 0.6.5 and performed a new install without any issue. Let me know if this fixes yours! Thanks.

Thx @ankon Helped to fix version:

  "resolutions": {
    "lz4": "0.6.3"
  }

and downgrade yarn: yarn policies set-version 1.21