lz4: The latest commit (move stuff to v2) breaks package with go 1.10 and earlier
Everything is in the name.
go get github.com/pierrec/lz4
package github.com/pierrec/lz4/v2/internal/xxh32: cannot find package "github.com/pierrec/lz4/v2/internal/xxh32" in any of:
/usr/lib/go-1.9/src/github.com/pierrec/lz4/v2/internal/xxh32 (from $GOROOT)
/***/gopath/src/github.com/pierrec/lz4/v2/internal/xxh32 (from $GOPATH)
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 23 (7 by maintainers)
Commits related to this issue
- #33: fixes go module support breaking non module aware go versions, kudos to @snowzach — committed to pierrec/lz4 by pierrec 6 years ago
Sorry about the inconvenience. Working on a fix ASAP.
For everyone doing plain go get, this was the workaround I’ve done while a fix is being developed:
git clone -b ‘v2.0.4’ --single-branch --depth 1 https://github.com/pierrec/lz4.git $GOPATH/src/github.com/pierrec/lz4
@pierrec I understand your point, but I still would like to point out that this is a breaking change for anyone not running 1.10, or using modules, or doing plain go get instead of using dep, glide, etc.
Could you please point out what would be the directions for everyone not ready to use modules?
@myusuf3 You need to upgrade 1.9 to 1.9.7. I have tested it successfully with this pkg at its current state. @nvnobelen yes, anything 1.10 before 1.10.4 breaks because of having v2 in the import path. @dayadev option2 would work but I dont think it is nice in the long run.
If no one objects to it, I will roll back the module support for now, until everyone is on a version of go that supports modules (that is 1.9.7+, 1.10.4+, 1.11 as we speak). Knowing when that happens may prove a challenge though…
Actually I’m also getting the same error with go version go1.10 linux/amd64
Building Shopify/sarama now fails because go get github.com/pierrec/lz4 fails.
I also run go1.10