enhancements: CoreOS Encrypted Disks By Default doc is not clear enough for installer changes

The installer team was looking at implementing the https://github.com/openshift/enhancements/blob/a3411e6f3458743ee2f84b013101d584fc272dc8/enhancements/automated-policy-based-disencryption.md#installer-support section, but the section is very brief in details that would allow somebody to implement the requested feature.

Here are some of the high-level questions that probably should be answered…

A) The installer can only provide the configurastion for nodes in form of MachineConfig objects. Therefore it would be highly useful there were example for MachineConfig objects that would define the encryption setting:

i) default (disable: false, enforce: true) ii) tpm2 based iii) tang based, multiple tang servers based iv) custom user based

B) The specs allow tpm2, tang etc. as source for encryption setup source, but there are no links or definition of valid values for these options.

C) The spec says the default is disable: false, enforce: true

that’s not a backward compatible change for install-config.yaml users, because users today expect to have no encryption…?

D) lack of clarity for default on cloud platforms.\

https://github.com/openshift/enhancements/blob/b5e77b5a99dc19de9acfa27fb0758ca42d74f3ee/enhancements/automated-policy-based-disencryption.md#policies

is also not clear on the defaults for cloud like AWS, Azure, GCP…

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 32 (27 by maintainers)

Most upvoted comments

A couple things concern me about enabling it on vSphere:

  1. The customer must have KMS setup to use a vTPM. We have no CI infrastructure with a KMS (at least in packet)
  2. The prerequisite text states: “The guest OS you use must be either Windows Server 2016 (64 bit) or Windows 10 (64 bit).” We need clarification from VMware if other OSes are supported.
  3. ESXi 6.7 and later only - 6.5 is supported to 2021

With those requirements I think that default disabled is more appropriate.

cc: @dav1x