cargo-semver-checks: Tests fail on nightly/beta 1.66+

Steps to reproduce the bug with the above code

Run cargo test using cargo 1.67.0-nightly (9286a1beb 2022-11-04)

Actual Behaviour

failures:

---- query::tests::derive_trait_impl_removed stdout ----
thread 'query::tests::derive_trait_impl_removed' panicked at 'assertion failed: `(left == right)`
  left: `[{"name": String("DebugFoo"), "path": List([String("semver_tests"), String("test_cases"), String("derive_trait_impl_removed"), String("DebugFoo")]), "span_begin_line": Uint64(7), "span_filename": String("src/test_cases/derive_trait_impl_removed.rs"), "trait_name": String("Debug"), "trait_path": List([String("core"), String("fmt"), String("Debug")]), "visibility_limit": String("public")}, {"name": String("CopyBar"), "path": List([String("semver_tests"), String("test_cases"), String("derive_trait_impl_removed"), String("CopyBar")]), "span_begin_line": Uint64(17), "span_filename": String("src/test_cases/derive_trait_impl_removed.rs"), "trait_name": String("Copy"), "trait_path": List([String("core"), String("marker"), String("Copy")]), "visibility_limit": String("public")}, {"name": String("EqFoo"), "path": List([String("semver_tests"), String("test_cases"), String("derive_trait_impl_removed"), String("EqFoo")]), "span_begin_line": Uint64(27), "span_filename": String("src/test_cases/derive_trait_impl_removed.rs"), "trait_name": String("Eq"), "trait_path": List([String("core"), String("cmp"), String("Eq")]), "visibility_limit": String("public")}]`,
 right: `[{"name": String("DebugFoo"), "path": List([String("semver_tests"), String("test_cases"), String("derive_trait_impl_removed"), String("DebugFoo")]), "span_begin_line": Uint64(7), "span_filename": String("src/test_cases/derive_trait_impl_removed.rs"), "trait_name": String("Debug"), "trait_path": List([String("core"), String("fmt"), String("Debug")]), "visibility_limit": String("public")}, {"name": String("CopyBar"), "path": List([String("semver_tests"), String("test_cases"), String("derive_trait_impl_removed"), String("CopyBar")]), "span_begin_line": Uint64(17), "span_filename": String("src/test_cases/derive_trait_impl_removed.rs"), "trait_name": String("Copy"), "trait_path": List([String("core"), String("marker"), String("Copy")]), "visibility_limit": String("public")}, {"name": String("EqFoo"), "path": List([String("semver_tests"), String("test_cases"), String("derive_trait_impl_removed"), String("EqFoo")]), "span_begin_line": Uint64(27), "span_filename": String("src/test_cases/derive_trait_impl_removed.rs"), "trait_name": String("StructuralEq"), "trait_path": List([String("core"), String("marker"), String("StructuralEq")]), "visibility_limit": String("public")}, {"name": String("EqFoo"), "path": List([String("semver_tests"), String("test_cases"), String("derive_trait_impl_removed"), String("EqFoo")]), "span_begin_line": Uint64(27), "span_filename": String("src/test_cases/derive_trait_impl_removed.rs"), "trait_name": String("Eq"), "trait_path": List([String("core"), String("cmp"), String("Eq")]), "visibility_limit": String("public")}, {"name": String("ManualEqFoo"), "path": List([String("semver_tests"), String("test_cases"), String("derive_trait_impl_removed"), String("ManualEqFoo")]), "span_begin_line": Uint64(38), "span_filename": String("src/test_cases/derive_trait_impl_removed.rs"), "trait_name": String("StructuralEq"), "trait_path": List([String("core"), String("marker"), String("StructuralEq")]), "visibility_limit": String("public")}]`', src/query.rs:260:9

Expected Behaviour

I expect the tests to pass.

Generated System Information

Software version

cargo-semver-checks 0.12.1

Operating system

Linux 6.0.6-arch1-1

Command-line

/home/tonowak/.cargo/bin/cargo-semver-checks semver-checks --bugreport

cargo nightly version

> cargo +nightly -V
cargo 1.67.0-nightly (9286a1beb 2022-11-04)

Compile time information

  • Profile: release
  • Target triple: x86_64-unknown-linux-gnu
  • Family: unix
  • OS: linux
  • Architecture: x86_64
  • Pointer width: 64
  • Endian: little
  • CPU features: fxsr,llvm14-builtins-abi,sse,sse2
  • Host: x86_64-unknown-linux-gnu

Additional Context

This appears to be due to a new marker trait StructuralEq added in 1.66+.

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 16 (7 by maintainers)

Most upvoted comments

I think it is reasonable to do the easiest solution and later consider improving it when in the future there’ll be a similar situation.