nx: Regression - Cypress executor does not respect env cli parameters.

Current Behavior

Regression of https://github.com/nrwl/nx/issues/9764. I upgraded from 14.2.4 where it worked.

Expected Behavior

Steps to Reproduce

This issue may not be prioritized if details are not provided to help us reproduce the issue.

Failure Logs

Environment

   Node : 16.13.0
   OS   : darwin x64
   yarn : 3.2.1
   
   nx : 14.3.6
   @nrwl/angular : Not Found
   @nrwl/cypress : 14.3.6
   @nrwl/detox : Not Found
   @nrwl/devkit : 14.3.6
   @nrwl/eslint-plugin-nx : 14.3.6
   @nrwl/express : Not Found
   @nrwl/jest : 14.3.6
   @nrwl/js : 14.3.6
   @nrwl/linter : 14.3.6
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : 14.3.6
   @nrwl/nx-cloud : Not Found
   @nrwl/nx-plugin : Not Found
   @nrwl/react : 14.3.6
   @nrwl/react-native : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : 14.3.6
   @nrwl/web : 14.3.6
   @nrwl/workspace : 14.3.6
   typescript : 4.7.4
   ---------------------------------------
   Community plugins:
         nx-stylelint: 13.4.0

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 30 (23 by maintainers)

Commits related to this issue

cleanup(testing): add extra e2e test asserting cypress env var behaviors cypress env arg parsing has had multiple regressions this change asserts the usage of commandline, cypress.env.json file, and ... — committed to barbados-clemens/nx by barbados-clemens 2 years ago
cleanup(testing): add extra e2e test asserting cypress env var behaviors cypress env arg parsing has had multiple regressions this change asserts the usage of commandline, cypress.env.json file, and ... — committed to barbados-clemens/nx by barbados-clemens 2 years ago
fix(core): serialize properly override with object arg for command line Avoid outputting object args as [object Object]. Is related to #10808 — committed to lukasalphta/nx by deleted user 2 years ago
fix(core): serialize properly override with object arg for command line Avoid outputting object args as [object Object]. Is related to #10808 — committed to lukasalphta/nx by deleted user 2 years ago
fix(core): serialize properly override with object arg for command line Avoid outputting object args as [object Object]. Is related to #10808 — committed to lukasalphta/nx by deleted user 2 years ago

Most upvoted comments

@danr-za that’s very interesting. presumably that should have just worked anyways, and also the fact it’s influencing the --env params is also interesting. I’ll investigate some on my side to see what I find, thanks for more info.

I assume that they are only logged this way --env=[object Object] but actually are passed correctly.

Correct, they will be still be passed to the executors as expected, unless you use DTE, where they are currently getting mangled, but presumably this recent change made will fix that.

I also have a PR up to document usage patterns with env that adds using --env.<value> to the cypress e2e tests so we can prevent any other regressions.

barbados-clemens on Aug 15, 2022

Hmm not us

danr-za on Aug 13, 2022