node-addon-api: Intermittent failure in ThreadSafe function

Failure in recent nightly run: @gabrielschulhof, @KevinEady as our threadsafe experts.

https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=fedora-latest-x64/3589/console

Running test 'threadsafe_function/threadsafe_function'


#
# Fatal error in , line 0
# Check failed: !object.IsSmi().
#
#
#
#FailureMessage Object: 0x7ffcf7a31110
 1: 0xae7a01  [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
 2: 0x1b043b4 V8_Fatal(char const*, ...) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
 3: 0xea7e92 v8::internal::PagedSpace::AllocateRawSlow(int, v8::internal::AllocationAlignment, v8::internal::AllocationOrigin) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
 4: 0xe3d8a6 v8::internal::Heap::AllocateRaw(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
 5: 0xe455c8 v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
 6: 0xe0925a v8::internal::Factory::AllocateRaw(int, v8::internal::AllocationType, v8::internal::AllocationAlignment) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
 7: 0xe04c72 v8::internal::FactoryBase<v8::internal::Factory>::AllocateRawArray(int, v8::internal::AllocationType) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
 8: 0xe04d24 v8::internal::FactoryBase<v8::internal::Factory>::NewFixedArrayWithFiller(v8::internal::Handle<v8::internal::Map>, int, v8::internal::Handle<v8::internal::Oddball>, v8::internal::AllocationType) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
 9: 0x1070bae v8::internal::Handle<v8::internal::FixedArray> v8::internal::String::CalculateLineEnds<v8::internal::Isolate>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::String>, bool) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
10: 0x1031483 void v8::internal::Script::InitLineEnds<v8::internal::Isolate>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Script>) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
11: 0x104554b v8::internal::Script::GetLineNumber(v8::internal::Handle<v8::internal::Script>, int) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
12: 0xdd5fc3 v8::internal::JSStackFrame::GetLineNumber() [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
13: 0xe13623 v8::internal::Factory::NewStackFrameInfo(v8::internal::Handle<v8::internal::FrameArray>, int) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
14: 0x1060928 v8::internal::StackTraceFrame::InitializeFrameInfo(v8::internal::Handle<v8::internal::StackTraceFrame>) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
15: 0x1060b00 v8::internal::StackTraceFrame::GetFrameInfo(v8::internal::Handle<v8::internal::StackTraceFrame>) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
16: 0x1063c85 v8::internal::SerializeStackTraceFrame(v8::internal::Isolate*, v8::internal::Handle<v8::internal::StackTraceFrame>, v8::internal::IncrementalStringBuilder*) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
17: 0x106480c v8::internal::SerializeStackTraceFrame(v8::internal::Isolate*, v8::internal::Handle<v8::internal::StackTraceFrame>) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
18: 0xcdb3d4  [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
19: 0xce32f6 v8::internal::Builtin_CallSitePrototypeToString(int, unsigned long*, v8::internal::Isolate*) [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
20: 0x1505f79  [/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-v16.0.0-nightly20210209beee53884d-linux-x64/bin/node]
Tests aborted with SIGILL
npm ERR! code 1
npm ERR! path /home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/node-addon-api
npm ERR! command failed
npm ERR! command sh -c node test

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/iojs/build/workspace/node-test-node-addon-api-new/nodes/fedora-latest-x64/npm-cache/_logs/2021-02-10T09_48_16_307Z-debug.log
Build step 'Conditional steps (multiple)' marked build as failure
Sending e-mails to: michael_dawson@ca.ibm.com gabriel.schulhof@intel.com Arunesh.Chandra@microsoft.com
Collecting metadata...
Metadata collection done.
Notifying upstream projects of job completion
Finished: FAILURE

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 75 (74 by maintainers)

Commits related to this issue

node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to mhdawson/io.js by mhdawson 3 years ago
node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to Trott/io.js by mhdawson 3 years ago
node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to mhdawson/io.js by mhdawson 3 years ago
node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to gabrielschulhof/node by mhdawson 3 years ago
node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to gabrielschulhof/node by mhdawson 3 years ago
node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to nodejs/node by mhdawson 3 years ago
node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to nodejs/node by mhdawson 3 years ago
test: Fix intermittent TSFN crashes Fixes: #906 — committed to KevinEady/node-addon-api by KevinEady 3 years ago
node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to gabrielschulhof/node by mhdawson 3 years ago
node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to nodejs/node by mhdawson 3 years ago
node-api: fix shutdown crashes Refs: https://github.com/nodejs/node-addon-api/issues/906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after i... — committed to mhdawson/io.js by mhdawson 3 years ago
node-api: fix shutdown crashes Refs: https://github.com/nodejs/node-addon-api/issues/906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after i... — committed to nodejs/node by mhdawson 3 years ago
node-api: fix shutdown crashes Refs: https://github.com/nodejs/node-addon-api/issues/906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after i... — committed to nodejs/node by mhdawson 3 years ago
node-api: fix shutdown crashes Refs: https://github.com/nodejs/node-addon-api/issues/906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after i... — committed to nodejs/node by mhdawson 3 years ago
node-api: fix shutdown crashes Refs: https://github.com/nodejs/node-addon-api/issues/906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after i... — committed to nodejs/node by mhdawson 3 years ago
node-api: fix shutdown crashes Refs: https://github.com/nodejs/node-addon-api/issues/906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after i... — committed to nodejs/node by mhdawson 3 years ago
node-api: fix shutdown crashes Refs: https://github.com/nodejs/node-addon-api/issues/906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after i... — committed to nodejs/node by mhdawson 3 years ago
node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to legendecas/node by mhdawson 3 years ago
node-api: fix shutdown crashes Refs: https://github.com/nodejs/node-addon-api/issues/906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after i... — committed to legendecas/node by mhdawson 3 years ago
node-api: fix crash in finalization Refs: https://github.com/nodejs/node-addon-api/issues/906 Refs: https://github.com/nodejs/node/pull/37616 Fix crash introduced by https://github.com/nodejs/node/p... — committed to nodejs/node by mhdawson 3 years ago

Most upvoted comments

Thjis is the SecondPassCallback method. Looking for where the invalid read might come from, but not obvious:

 static void SecondPassCallback(
      const v8::WeakCallbackInfo<SecondPassCallParameterRef>& data) {
    SecondPassCallParameterRef* parameter = data.GetParameter();
    Reference* reference = *parameter;
    delete parameter;
    if (reference == nullptr) {
      // the reference itself has already been deleted so nothing to do
      return;
    }
    reference->Finalize();
  }

mhdawson on May 2, 2021