node-addon-api: Intermittent crashes in CI
There have been a few recent crashes (maybe 3 in last 15 or so days) in the CI https://ci.nodejs.org/view/x - Abi stable module API/job/node-test-node-addon-api-LTS versions/
A number of the failures look like the following just before the crash
Running test 'objectwrap_constructor_exception'
Running test 'objectwrap_multiple_inheritance'
Running test 'objectwrap_worker_thread'
Running test 'promise'
Running test 'reference'
Running test 'run_script'
Running test 'symbol'
Running test 'threadsafe_function/threadsafe_function'
Running test 'threadsafe_function/threadsafe_function_ctx'
Tests aborted with SIGSEGV
napiVersion:8
Testing with Node-API Version '8'.
Starting test suite
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 19 (19 by maintainers)
Commits related to this issue
- doc: update tests to avoid running in parallel fixes: https://github.com/nodejs/node-addon-api/issues/1022 The objectwrap_worker_thread and symbol tests were not waiting for the test to complete bef... — committed to mhdawson/node-addon-api by mhdawson 3 years ago
- doc: update tests to avoid running in parallel fixes: https://github.com/nodejs/node-addon-api/issues/1022 The objectwrap_worker_thread and symbol tests were not waiting for the test to complete bef... — committed to deepakrkris/node-addon-api by mhdawson 3 years ago
- doc: update tests to avoid running in parallel fixes: https://github.com/nodejs/node-addon-api/issues/1022 The objectwrap_worker_thread and symbol tests were not waiting for the test to complete bef... — committed to deepakrkris/node-addon-api by mhdawson 3 years ago
- doc: update tests to avoid running in parallel fixes: https://github.com/nodejs/node-addon-api/issues/1022 The objectwrap_worker_thread and symbol tests were not waiting for the test to complete bef... — committed to kevindavies8/node-addon-api-Develop by kevindavies8 3 years ago
- doc: update tests to avoid running in parallel fixes: https://github.com/nodejs/node-addon-api/issues/1022 The objectwrap_worker_thread and symbol tests were not waiting for the test to complete bef... — committed to Marlyfleitas/node-api-addon-Development by Marlyfleitas 3 years ago
- doc: update tests to avoid running in parallel fixes: https://github.com/nodejs/node-addon-api/issues/1022 The objectwrap_worker_thread and symbol tests were not waiting for the test to complete bef... — committed to wroy7860/addon-api-benchmark-node by wroy7860 3 years ago
- doc: update tests to avoid running in parallel fixes: https://github.com/nodejs/node-addon-api/issues/1022 The objectwrap_worker_thread and symbol tests were not waiting for the test to complete bef... — committed to austinli64/node-addon-api by austinli64 3 years ago
- doc: update tests to avoid running in parallel fixes: https://github.com/nodejs/node-addon-api/issues/1022 The objectwrap_worker_thread and symbol tests were not waiting for the test to complete bef... — committed to johnfrench3/node-addon-api-git by deleted user 3 years ago
15000 runs with the refactor and looking good. Heading out for a long weekend so I don’t want to leave running but I’ll kickoff longer run on Tuesday and then follow up with PR if its still looks good.
Turns out the worker in objectwrap_worker_thread was running in parallel with other tests, not sure if that is related to the crash but have a refactored version that makes sure worker has completed before running the rest of the tests to test out.