vscode: Maximized window with custom title bar places 1px on second monitor (regression)
Issue Type: Bug
Workaround: In my case it appears only after exiting Full Screen or Zen Mode. So if you don’t use them often - just close and open VS Code - dimensions will be OK. If you use FS/ZM - dimensions should be ok if you activate FS/ZM again.
Similar issue was reported for 1.39 #83968 and fixed in 1.40.
However with latest Insider update it reappeared again.
(maximized window is a bit wider that Windows task bar, so that 1px is rendered on second monitor)
Steps to reproduce:
- Make sure that
"window.titleBarStyle": "custom"(default) - Make sure that you have more than 1 monitor 😄 (checked on horizontal layout of monitors)
- Maximize window and check second monitor (contrast background image helps)
I believe after #85266
/cc @deepak1556
VS Code version: Code - Insiders 1.41.0-insider (f24f483428f592a262dc73d68a3f05745c562b31, 2019-11-21T10:43:20.960Z) OS version: Windows_NT x64 10.0.18362
System Info
| Item | Value |
|---|---|
| CPUs | Intel® Core™ i7-8700 CPU @ 3.20GHz (12 x 3192) |
| GPU Status | 2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: enabled rasterization: enabled skia_renderer: disabled_off surface_control: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off webgl: enabled webgl2: enabled |
| Load (avg) | undefined |
| Memory (System) | 31.72GB (16.35GB free) |
| Process Argv | |
| Screen Reader | no |
| VM | 0% |
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 14
- Comments: 18 (11 by maintainers)
This happens with almost every electron app now, whether it is Discord, VSCode, Postman or Whatsapp
@deepak1556 yes, looks like latest insiders build fixes this issue on my PC.
Version: 1.51.0-insider (user setup) Commit: 89c002ab02f87102d91efc83c191ef1174756c6a Date: 2020-10-15T23:17:08.035Z Electron: 9.3.2
Thanks for testing, closing as fixed.
Yup reverted it for https://github.com/microsoft/vscode/issues/106801 to be addressed in next milestone.
Thanks for the report, yeah became aware of this in my setup as well. I might not target this fix for another stable recovery but rather will target the insiders.