vscode: Maximize button not working properly with auto-hide taskbar enabled

Version: 1.39.0-insider (user setup) Commit: cc481ab31b5827add5f99a770f2c860d0575df69 Date: 2019-09-18T07:02:14.165Z Electron: 6.0.9 Chrome: 76.0.3809.146 Node.js: 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0.18362

Steps to Reproduce:

Start VS code in normal window state
Maximize it through the maximize button

Expected result - VS Code maximizes and the button changes to it’s maximized glyph, user is able to restore to normal window through the same button Actual result - VS Code maximizes visually, BUT the window actually just takes the screen size while remains draggable and the glyph remains the one for the normal state. The user is unable to restore normal state by clicking ti again.

Note : the maximize/restore by double clicking the title bar works normally.

Does this issue occur when all extensions are disabled?: Yes

About this issue

Original URL
State: closed
Created 5 years ago
Reactions: 15
Comments: 41 (14 by maintainers)

Most upvoted comments

Thanks for the reports, the issue is being actively worked on , fix is already up on electron end https://github.com/electron/electron/pull/21164 and will soon be available in the next vscode stable recovery release later this week.

deepak1556 on Nov 18, 2019

Fixed with https://github.com/microsoft/vscode/pull/85266

deepak1556 on Nov 21, 2019

Thanks for the details @fireattack , yeah the root cause is same for this case.

deepak1556 on Nov 13, 2019

@deepak1556

I investigated it further.

In my case, it was related to an instant messenger program, QQ, the most popular IM in China.

The way it works is that you can have it sticked to the top or side of the screen (and always display on top). So you can reveal the main GUI by simply move the cursor to that part.

How it looks like when it hides:

(notice the shadow)

How it looks when it reveals:

But this causes problem on VS Code’s maximizing function, like what the other has said:

the window maximize button doesn’t maximize the window, it just makes it as large as the screen (the window state and button appearance don’t change) and the window doesn’t restore when clicking again.

This actually reminds me of another program, Steam, which has a similar problem. In that case, you literally can’t maximize at all (not even with double-click on title bar), it will always just make the window as big as the screen, sans 1px on top due to QQ.

I should stress, this is a regression. I’ve been using both VS Code and QQ together for a very long time and there was no problem.

fireattack on Nov 13, 2019

@lllopo makes sense as we’ve returned to electron 6 but are tracking this issue as part of that process

sbatten on Oct 11, 2019