vscode: Hitting enter on suggestion doesn't import module
Issue Type: Bug
For this example I’ll be using React.
I have the following components;
import styled from "styled-components";
type Justify = "space-around" | "space-between";
export const FlexBox = styled.div<{
column?: boolean;
justify?: Justify;
}>`
display: flex;
flex-direction: ${props => (props.column ? "column" : "row")};
${props => !!props.justify && `justify-content: ${props.justify}`}
`;
export const Flex = styled.div<{ flex?: number }>`
flex: ${props => props.flex || 1};
`;
When I try to use them inside another component I do get an auto completion with the correct name whilst typing FlexBox but when I hit enter it doesn’t import it (it does complete it), clicking on the suggestion with my mouse does work.
Here’s a video describing the problem;
https://monosnap.com/file/dqiy5IbunVfW9ExUZqFwusQy7EErdB
edit: It does show up as a quick fix to import it.
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:22:55.268Z) OS version: Darwin x64 17.7.0
System Info
| Item | Value |
|---|---|
| CPUs | Intel® Core™ i5-6267U CPU @ 2.90GHz (4 x 2900) |
| GPU Status | 2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled |
| Load (avg) | 6, 4, 4 |
| Memory (System) | 8.00GB (0.03GB free) |
| Process Argv | |
| Screen Reader | no |
| VM | 0% |
Extensions (43)
| Extension | Author (truncated) | Version |
|---|---|---|
| atlascode | atl | 1.3.0 |
| vscode-custom-css | be5 | 3.0.4 |
| vscode-intelephense-client | bme | 1.0.14 |
| scratchpads | bue | 0.0.5 |
| better-phpunit | cal | 1.4.0 |
| path-intellisense | chr | 1.4.2 |
| laravel-goto-view | cod | 1.2.5 |
| bracket-pair-colorizer-2 | Coe | 0.0.28 |
| vscode-markdownlint | Dav | 0.26.0 |
| vscode-eslint | dba | 1.8.2 |
| gitlens | eam | 9.6.3 |
| vsc-material-theme | Equ | 2.8.2 |
| carbon-now-sh | eri | 1.2.0 |
| prettier-vscode | esb | 1.9.0 |
| git-project-manager | fel | 1.7.1 |
| php-debug | fel | 1.13.0 |
| code-runner | for | 0.9.9 |
| macros | ged | 1.2.1 |
| rest-client | hum | 0.21.2 |
| vscode-styled-components | jpo | 0.0.26 |
| php-namespace-resolver | Meh | 1.1.7 |
| vscode-language-babel | mgm | 0.0.22 |
| dotenv | mik | 1.0.1 |
| vscode-typescript-tslint-plugin | ms- | 1.0.0 |
| debugger-for-chrome | msj | 4.11.3 |
| php-docblocker | nei | 1.8.0 |
| vscode-extension-auto-import | Nuc | 1.4.3 |
| laravel-blade | one | 1.20.0 |
| laravel-extension-pack | one | 0.5.0 |
| laravel5-snippets | one | 1.5.0 |
| vscode-jest | Ort | 2.9.2 |
| material-icon-theme | PKi | 3.7.0 |
| text-power-tools | qcz | 1.11.1 |
| markdown-preview-theme-one-dark | rae | 0.0.1 |
| vscode-yaml | red | 0.4.0 |
| code-settings-sync | Sha | 3.2.9 |
| mdx | sil | 0.1.0 |
| laravel-goto-controller | ste | 0.0.7 |
| vscode-laravel-assist | tia | 0.1.6 |
| vscode-markdown-link-suggestions | Tom | 13.0.0 |
| vscode-mdx-preview | xyc | 0.1.5 |
| vscode-surround | yat | 1.0.2 |
| markdown-all-in-one | yzh | 2.3.1 |
(3 theme extensions excluded)
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 17 (14 by maintainers)
Commits related to this issue
- move commit character logic to its own file, #73311 — committed to microsoft/vscode by jrieken 5 years ago
- resolve completion item before inserting (except when using commit characters), #73311 — committed to microsoft/vscode by jrieken 5 years ago
- Revert "resolve completion item before inserting (except when using commit characters), #73311" This reverts commit b513141f5d7b0728b3dfa2e0637c42a71351714d. — committed to microsoft/vscode by jrieken 5 years ago
- selecting an item should insert it sync, #73311 — committed to microsoft/vscode by jrieken 5 years ago
- renames, #73311 — committed to microsoft/vscode by jrieken 5 years ago
- adding doc about resolve and not waiting when accepting, #73311 — committed to microsoft/vscode by jrieken 5 years ago
- show Loading... in details view, #73311 — committed to microsoft/vscode by jrieken 5 years ago
This comes up constantly in my experience and I hope a fix can be implemented! Here’s the detail I filed at: https://github.com/microsoft/vscode/issues/106361
Steps to Reproduce:
Result: Autocomplete happens but variable is not found because auto-import failed
(Auto-import only succeeds if I wait an extra 0.5+ seconds until the Auto-Import suggestion loads.)
Expected: If Auto-Import is turned on then Autocomplete of a variable not in the current file already should always auto-import; probably a Tab press should just bring up the Autocomplete suggestions or should not process until after that, because an autocompleted but not imported item that’s going to be invalid seems likely to almost never be what the user wants.
Notes: This took me a long time to diagnose because Auto-import usually just failed and I couldn’t figure out why. It seems to me an unexpected and erroneous state if VS Code believes it can find an import, then autocompletes it, then afterward it’s not found and invalid.
This also slows down the user every time trying to Autocomplete because it will often be unknown if the import has been imported yet or not; if so then fast autocomplete is possible, if not then the user must wait for the Auto-Import box to show up or if autocomplete Tab press was submitted quickly, go back and autocomplete again, this time waiting for the auto-import box.
Fixing this would probably save millions of times 1 second as autocompletes unexpectedly don’t auto-import. Just finally understanding this issue is saving me a lot of frustration.
Thanks for taking a look and for the great app.
Does this issue occur when all extensions are disabled?: Yes
Thank you for checking. The details should never take this long to load. I’ve opened https://github.com/microsoft/TypeScript/issues/31302 to look into why this is happening
If you trigger suggestions and then wait until the details for that suggestion show up, I suspect it the import should be added as expected. @jordyvandomselaar Can you please test this
@jrieken I debugged this issue and believe the root cause is that we are accepting a completion item that is not resolved. This was previously detailed in #63013 but we had to revert that fix as it caused other regressions.