lottie-react-native: Upgrade lottie-android to 2.8.0 - Invalid Layer Save Flag Issue
Description
I’m experiencing this issue https://github.com/airbnb/lottie-android/issues/802
Looks like we’re using 2.5.5 https://github.com/react-community/lottie-react-native/blob/d9f1c88c02c7a38cc81d18009585c07942f387b4/src/android/build.gradle#L30
Which has the following line that causes some issues with newer versions of Android https://github.com/airbnb/lottie-android/blob/95f07d18ba24b36c114ecdc1d7274971ad490172/lottie/src/main/java/com/airbnb/lottie/model/layer/BaseLayer.java#L367
Steps to Reproduce
Follow the step in the associated ticket.
Expected behavior:
The animation should work
Actual behavior:
The animation causes the app to crash
Versions
2.5.*
You can get this information from executing npm version.
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 26 (11 by maintainers)
oh! so the problem is Android SDK v28.0.0
now I know how to reproduce so I will give it a try.
@emilioicai For me the app still crashes when using master:
"lottie-react-native": "https://github.com/react-community/lottie-react-native.git#13aa84aa2b1836034cef53c250866eba634e6b65",I did clean the project from Android Studio and rebuilt-it after changingpackage.jsonand runningnpm i.What is preventing us from migrating to Lottie 3.0.0 at this point? Wondering if anyone has an existing PR for that.
Our app crashes with this issue at runtime with the most up-to-date dependencies:
@7ynk3r apparently updating to lottie-android 2.5.6 is useful and easy so I will update this repo to use that version. You can use master and check if it works.
Any update about this, the crash still happens!
I got this issue on some animation on android P target sdk 28.0.0 lottie version 2.5.4
@schumannd It seems to happen only on specific animations. I haven’t done enough diving into the animations to see what causes some of them to crash, but I can definitely confirm that some animations work fine on the 28 SDK, and some do not. We are playing it safe and staying with 27 until this is resolved.
@emilioicai Indeed it still crashes on master with Android SDK v28.0.0. It works fine on your master branch with Android SDK v27.0.0. We would love to get our project back on the newest Android SDK, so I hope this issue is fixed soon.
Thanks @MaxToyberman ! I will update this repo with your suggested changes
I haven’t try yet. I’ll see if I have time tonight.