livebook: Close previous modal errors when compilation succeeds
Environment
- Elixir & Erlang/OTP versions (elixir --version): 1.13.1
- How have you started Livebook (mix phx.server, livebook CLI, Docker, etc): livebook server
- Livebook version (use
git rev-parse HEADif running with mix): 0.4.1
Current behavior
Runtime settings: Mix Standalone I am already connected. I edit my local .ex files, and hit RECONNECT to recompile and reload changes. I get a modal error saying (I know it is a compilation error):
"Failed to setup runtime - running mix compile failed, see output for more details"
Where is that log? I click on the modal, the modal closes, I don’t see any log.
Anyway…
I hit Reconnect again and I get the same error, I leave it open this time.
I fix the error in my .ex file, save it, I hit Reconnect, it works. but the message
"Failed to setup runtime - running mix compile failed, see output for more details"
is still there. I think it should be closed automatically.
Expected behavior
Close all the open errors related to a failed compilation.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 16 (16 by maintainers)
That is a really good trick! and yes, the screencast in the PR works as expected.
See #837.
@eksperimental ftr it’s also useful to have
IEx.Helpers.recompile()in the first cell and evaluate that instead of restarting everything 😃