test-infra: k8s-ci-robot shouldn't label "sig/api-machinery" if k8s-merge-robot comments "@kubernetes/sig-api-machinery-misc"
k8s-merge-robot comments on every issues which don’t have a sig label. The comment includes e.g., @kubernetes/sig-api-machinery-misc for API Machinery(this example was added in #3102 as suggested in #3060). This comment leads to k8s-ci-robot labels “sig/api-machinery” for every issues. This is not expected. We should find a better way to address it.
/cc @@grodrigues3 @spxtr @crimsonfaith91
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Comments: 26 (26 by maintainers)
@spxtr @krzyzacy @xiangpengzhao @grodrigues3 The behavior is not due to sig-mention munger, but the regex for label plugin: https://github.com/kubernetes/test-infra/blob/master/prow/plugins/label/label.go#L47
Based on how the regex is written, a notification will be triggered even it is quoted or tailed with other words behind. I will get the regex fixed tomorrow. Thanks!
@xiangpengzhao Quotation should not trigger any sig mentioning. It means that it is due to another issue. I am investigating it now. @spxtr @krzyzacy @grodrigues3 It looks like the changes have been deployed. Thanks for the help! 😃
@spxtr I have no idea about submit-queue yet, I’ll work with @cjwagner Monday. It probably should be documented somewhere so that we can all be able to do this.