test-infra: k8s-ci-robot doesn't remove `do-not-merge/work-in-progress` label from draft PRs
What happened:
A PR I made in kubernetes/sig-release was started as a draft (waiting for another PR to merge). When I pressed the “ready for review” button, k8s-ci-robot did not remove the do-not-merge/work-in-progress so despite approval, the PR was not merged.
What you expected to happen: When draft PRs are ready for review, the do-not-merge/work-in-progress label should be removed by k8s-ci-robot
How to reproduce it (as minimally and precisely as possible): Create a draft PR on a kubernetes repo. Then make it “ready for review”
Please provide links to example occurrences, if any: https://github.com/kubernetes/sig-release/pull/565 Anything else we need to know?: You’re awesome 🥇
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 3
- Comments: 16 (10 by maintainers)
@stevekuznetsov Thanks a lot, for the help. I’ll start working on it right away.
Ah, it’s a new type of event,
pull_request.ready_for_reviewas mentioned here. As communicated here the events should now be sent. So we need to update the pull request event types to add the new one and update the plugin to respond to that type.I would like to work on this, if anyone else isn’t.