core: Picnic todo list broken

The problem

Whenever I try to add a basic item to the todo list, it will fail.

cc @DCSBL

What version of Home Assistant Core has the issue?

2024.4.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Picnic

Link to integration documentation on our website

https://www.home-assistant.io/integrations/picnic/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.helpers.script.websocket_api_script
Source: helpers/script.py:1918
First occurred: 11:10:39 (1 occurrences)
Last logged: 11:10:39

websocket_api script: Error executing script. Error for call_service at pos 1: No product found or no product ID given

Additional information

No response

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 21 (8 by maintainers)

Most upvoted comments

I’ve gone ahead and forked the python library, merged https://github.com/MikeBrink/python-picnic-api/pull/26 and fixed https://github.com/MikeBrink/python-picnic-api/issues/27 (https://github.com/home-assistant/core/issues/138735).

I am planning to maintain this fork for as long as it is feasible* and released it on PyPi: https://pypi.org/project/python-picnic-api2/

I am currently in the middle of getting things up to date and working again so that I have a good workflow, but I already know of 3 people using the fork as a custom component in HA. The core component will only require changing the library’s name, but I really want to wait for @corneyl 's feedback about this.

* It seems like picnic is migrating from a data-driven API to an API which returns hundreds of kilobytes of JSON containing hydrated widgets. This means that picnic can change the app’s layout without pushing an update, but also makes life a lot harder for me, since the library has to re-arrange text, buttons, and hyperlinks into actual useful data. I do not believe this will get any easier; in fact, I bet they will change the remaining endpoints too in the future. I will try adapting to these changes as good as possible, but if things break too periodically, the picnic component might be too unstable for a core component, if at all. Additionally, one could argue that the new API falls under ADR004

It seems Picnic has changed the search API a while ago, and a fix has been proposed. But it seems the library has been abandoned. Which is fine, priorities change, but as this is a really cool feature we should see how we can fix this for the rest.

I think the best route to fix this is forking the library and applying the proposed fixes. I am open to take over the maintenance but maybe there is a better route. @joostlek, what is common practice on an issue like this?

@corneyl Could you please take a look at the above PR? Would like to be able to use this integration again. Thanks.

Hi @monkeydriven, sorry, I’ve not been able to find time to look at this. hopefully I can find some time soon…

@AnonymousMiz this is not Facebook. Please use the subscribe button for that.

Image

It seems that there is an open PR for the library that should fix the issue but the author has not responded to the PR yet. I tried to contact the author in the PR here: https://github.com/MikeBrink/python-picnic-api/pull/25