core: Picnic add_product not working

The problem

When executing the action picnic.add_product, an error will appear and no product is added.

Action used:

action: picnic.add_product
data:
  config_entry_id: 01J69JCRJYRXSYKYZGRJ554QHF
  product_name: "Pink lady"

Pink Lady is an actual name of an apple listed. Also tried Coca cola and other specific grocery names. Same restult in log:

2025-01-18 12:49:13.680 ERROR (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Error executing script. Unexpected error for call_service at pos 1: No product found or no product ID given!
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 526, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 764, in _async_call_service_step
    response_data = await self._async_run_long_action(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<9 lines>...
    )
    ^
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 727, in _async_run_long_action
    return await long_task
           ^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2795, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2838, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/picnic/services.py", line 37, in async_add_product_service
    await handle_add_product(hass, api_client, call)
  File "/usr/src/homeassistant/homeassistant/components/picnic/services.py", line 72, in handle_add_product
    raise PicnicServiceException("No product found or no product ID given!")
homeassistant.components.picnic.services.PicnicServiceException: No product found or no product ID given!

What version of Home Assistant Core has the issue?

core-2025.1.2

What was the last working version of Home Assistant Core?

NA

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Picnic

Link to integration documentation on our website

https://www.home-assistant.io/integrations/picnic/

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 21 (13 by maintainers)

Commits related to this issue

Most upvoted comments

@home-assistant add-label needs-more-information

Note: I am on Core 2025.3.2 and also get Error: No product found or no product ID given!. I will test again once your fix is in the new HA release.

@hmmbob I acquired access to an account in the Netherlands and noticed that the API behaved slightly different. I was still able to add the account to a fresh HA instance and add cola zero to the cart. I’d be interested in what @dhoeben observes with 2025.3, but at this point in time I am sadly unable to reproduce the issue.

I will revisit this once in a while and add proper logging so that we can have a look at debugging output.

Problem was still from before the API fix you did! I keep you posted

@hmmbob I acquired access to an account in the Netherlands and noticed that the API behaved slightly different. I was still able to add the account to a fresh HA instance and add cola zero to the cart. I’d be interested in what @dhoeben observes with 2025.3, but at this point in time I am sadly unable to reproduce the issue.

I will revisit this once in a while and add proper logging so that we can have a look at debugging output.

This is NOT fixed by #139111: running HA 2025.3.0b0 and the error is still the same

/cc @codesalatdev

I am also running that beta version and it’s working fine for me; is the error still the same? If not, can you share the error here? Also, it would be helpful if you tell us your country code and what product you’ve tried adding.

Thank you for the update