nexus-plugin-prisma: Possible bug: Nexus-prisma is causing multiple queries to be run for a single query

Background: We just implemented prisma-nexus into our project. We are using apollo-server and graphql-middleware. Upon introducing prisma-nexus, we saw a huge dip in performance during testing. This lead me to investigate.

Problem: I’m seeing some extremely inefficient behavior with queries generated by nexus-prisma. Sometimes at a point where my prisma DB gets overloaded by queries and becomes unresponsive for a second or two. There’s a lot of cases I’m seeing where it seems nexus-prisma is taking one query and breaking them out into multiple queries (the highest I saw was 213 queries). I’ve just picked two to illustrate my point.

It seems the issue arises when the query is selecting relational properties and enum properties. The first query I’m sending through illustrates the relational properties issue. The second illustrates enum properties. These show the query inefficiencies.

Note 1: I’ve turned on query logging on my prisma DB. This is how I was able to see this and grab the queries. Note 2: Worried that my team and I had done something wrong with our implementation, I cloned the repo and ran the example (nexus-prisma/example) code against my prisma DB and saw the exact same behavior.

QUERY 1 query { userProfiles(where:{id:"cjoal2g9501im08129j5xc6kv"}) { id favorites{title} } } Note: favorites is the relation property (array of Favorite)

Results in 2 prisma queries being run: This one gets ALL non-relational properties for the UserProfile … even though we’re just querying for id and favorites.

[{"query":"query ($where: UserProfileWhereInput) { userProfiles(where: $where) { id oktaId firstName lastName userName email phone status countryCode profilePicture location pending defaultLandingPage dateFormat timeFormat lastActive accountAdmin programAdmin employee authId createdAt updatedAt } } ","variables":{"where":{"id":"cjoal2g9501im08129j5xc6kv"}}}]

This one just gets the Favorite (relational property) and all non-relational properties of the Favorite [{"query":"query ($where: UserProfileWhereUniqueInput!) { userProfile(where: $where) { favorites { id title url subdomain relativePath openNewTab sortOrder createdAt updatedAt } } } ","variables":{"where":{"id":"cjoal2g9501im08129j5xc6kv"}}}]

QUERY 2 query { userProfiles(where:{}) { status } } Note:Status is UserProfileStatus, an enum.

There are 82 UserProfiles Results in 83 (!) prisma queries (this only happens when including an enum value in the query):

The preliminary one; gets ALL non-relational properties for the UserProfile [{"query":"query ($where: UserProfileWhereInput) { userProfiles(where: $where) { id oktaId firstName lastName userName email phone status countryCode profilePicture location pending defaultLandingPage dateFormat timeFormat lastActive accountAdmin programAdmin employee authId createdAt updatedAt } } ","variables":{"where":{}}}]

The next 82 are the same query…just querying on status for each UserProfile:

[{"query":"query ($where: UserProfileWhereUniqueInput!) { userProfile(where: $where) { status } } ","variables":{"where":{"id":"cjoal2g9501im08129j5xc6kv"}}} ,{"query":"query ($where: UserProfileWhereUniqueInput!) { userProfile(where: $where) { status } } ","variables":{"where":{"id":"cjoeybj5702r30812g6fmz24d"}}} ... 80 more queries - all with different ids ... ]

Here’s our relevant types for the datamodel.prisma file: type UserProfile { id: ID! @unique oktaId: ID firstName: String! lastName: String! userName: String email: String! @unique phone: String --> status: UserProfileStatus! userGroup: UserGroup --> favorites: [Favorite!]! notifications: [Notification!]! countryCode: String profilePicture: String location: String pending: Boolean defaultLandingPage: LandingPage dateFormat: String timeFormat: String lastActive: String accountAdmin: Boolean! @default(value: "false") programAdmin: Boolean! @default(value: "false") employee: Boolean! @default(value: "false") userPrograms: [UserProgram!]! @relation(name: "UserAndUserProgram" onDelete: CASCADE) authId: String! @unique accountUsers: [AccountUser!]! @relation(name: "UserAndAccountUser" onDelete: CASCADE) createdAt: DateTime! updatedAt: DateTime! }

type Favorite { id: ID! @unique title: String! url: String subdomain: String relativePath: String openNewTab: Boolean! sortOrder: Int! users: [UserProfile!]! createdAt: DateTime! updatedAt: DateTime! }`

enum UserProfileStatus { DISABLED LOCKED ACTIVE }