go: x/tools/gopls/internal/test/integration/completion: unrecognized failures

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""

Issue created automatically to collect these failures.

Example (log):

panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18579 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0022470e0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xd6e0e85?, 0xc00002d670?}, {0xc00002d738?, 0x1d?, 0xcc54100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00002d870, 0x1, 0xcc5ca1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc005d37d80?, 0xc002443d40?, 0x5e?}, {0xd689a15?, 0x3?}, 0xf0?, 0x6e?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0038b04e0, {0xdb72108, 0xc002dc4600}, 0xc0021fd320)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0038b04e0, {0xdb72108, 0xc002dc4600}, 0x0, {0xc001ea2b40, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/sync@v0.5.0/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18557
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/sync@v0.5.0/errgroup/errgroup.go:72 +0x96

— watchflakes

About this issue

Original URL
State: closed
Created 7 months ago
Reactions: 1
Comments: 34 (4 by maintainers)

Most upvoted comments

Aha, ok I understand and can reproduce this locally now.

findleyr on Dec 1, 2023

Of course, I’ve run this hundreds of times on both netbsd and openbsd gomotes, with 0 failures so far.

findleyr on Dec 1, 2023

It looks like this bug was triggered by https://go.dev/cl/541277 (the panics appear to be completion tests), but that CL is almost certainly not the root cause.

So this is great news: since this looks highly reproducible, at least on BSDs, it is likely that we will be able to root cause a formerly latent bug.

CC @adonovan

findleyr on Dec 1, 2023