go: x/tools/gopls/internal/regtest/modfile: TestUnknownRevision failure with `All files must be saved first`

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && 
        test == "TestUnknownRevision" && `All files must be saved first`

greplogs -l -e 'FAIL: TestUnknownRevision.*(?:\n\s+.*)*All files must be saved first' --since=2022-02-01 2022-09-07T18:17:13-3ee1710-dfdf551/linux-s390x-ibm 2022-09-07T16:39:44-dd1bab2-027ff3f/linux-s390x-ibm

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 19 (2 by maintainers)

Most upvoted comments

I see the race in this test: the test may advance to applying code actions before changes are processed (because there is both a didChange and didSave notification being processed, and we proceed once either of them is done, not both).

I have an in-progress improvement to our expectations that should make it easy to fix this.

findleyr on Sep 14, 2022