fastlane: [FrameIt] Cannot generate framed screenshot correctly for iPads + certain languages
New Issue Checklist
- Updated fastlane to the latest version
- I read the Contribution Guidelines
- I read docs.fastlane.tools
- I searched for existing GitHub issues
Issue Description
I can generate:
- iphone/ipad framed screenshot for languages like French
- iphone framed screenshots for Japanese
However I cannot generate:
- ipad framed screenshots for Japanese (and a couple of languages like Chinese etc)
Command executed
fastlane frameit
Complete output when running fastlane, including the stack trace and command used
[10:44:11]: fastlane detected a Gemfile in the current directory [10:44:11]: However, it seems like you didn't use `bundle exec` [10:44:11]: To launch fastlane faster, please use [10:44:11]: [10:44:11]: $ bundle exec fastlane frameit [10:44:11]: [10:44:11]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile [10:44:12]: Using device frames version 'latest' [✔] Framing screenshot './ja/iphone_xs_max_1_home_page.png' [10:44:30]: Added frame: '/Users/chenkaty/Documents/FaxGun/fastlane/screenshots/ja/iphone_xs_max_1_home_page_framed.png' [⠙] Framing screenshot './ja/iPadPro12.9-inch2ndGeneration_home_page.png' identify: geometry does not contain image `/var/folders/n1/qp1sbb_j1f1_s7ds03wjxmrw0000gn/T/mini_magick20200307-68816-m21bj1.png' @ warning/attribute.c/GetImageBoundingBox/507. [⠇] Framing screenshot './ja/iPadPro12.9-inch2ndGeneration_home_page.png' identify: geometry does not contain image `/var/folders/n1/qp1sbb_j1f1_s7ds03wjxmrw0000gn/T/mini_magick20200307-68816-169jn50.png' @ warning/attribute.c/GetImageBoundingBox/507. [⠙] Framing screenshot './ja/iPadPro12.9-inch2ndGeneration_home_page.png' mogrify: geometry does not contain image `/var/folders/n1/qp1sbb_j1f1_s7ds03wjxmrw0000gn/T/mini_magick20200307-68816-m21bj1.png' @ warning/transform.c/CropImage/643. [⠸] Framing screenshot './ja/iPadPro12.9-inch2ndGeneration_home_page.png' mogrify: geometry does not contain image `/var/folders/n1/qp1sbb_j1f1_s7ds03wjxmrw0000gn/T/mini_magick20200307-68816-169jn50.png' @ warning/transform.c/CropImage/643. [✔] Framing screenshot './ja/iPadPro12.9-inch2ndGeneration_home_page.png' [10:45:08]: Added frame: '/Users/chenkaty/Documents/FaxGun/fastlane/screenshots/ja/iPadPro12.9-inch2ndGeneration_home_page_framed.png' [⠏] Framing screenshot './ja/ipad_pro_3rd_gen_home_page.png' identify: geometry does not contain image `/var/folders/n1/qp1sbb_j1f1_s7ds03wjxmrw0000gn/T/mini_magick20200307-68816-t1wxlr.png' @ warning/attribute.c/GetImageBoundingBox/507. [⠦] Framing screenshot './ja/ipad_pro_3rd_gen_home_page.png' identify: geometry does not contain image `/var/folders/n1/qp1sbb_j1f1_s7ds03wjxmrw0000gn/T/mini_magick20200307-68816-1q4v0j1.png' @ warning/attribute.c/GetImageBoundingBox/507. [⠇] Framing screenshot './ja/ipad_pro_3rd_gen_home_page.png' mogrify: geometry does not contain image `/var/folders/n1/qp1sbb_j1f1_s7ds03wjxmrw0000gn/T/mini_magick20200307-68816-t1wxlr.png' @ warning/transform.c/CropImage/643. [⠙] Framing screenshot './ja/ipad_pro_3rd_gen_home_page.png' mogrify: geometry does not contain image `/var/folders/n1/qp1sbb_j1f1_s7ds03wjxmrw0000gn/T/mini_magick20200307-68816-1q4v0j1.png' @ warning/transform.c/CropImage/643. [✔] Framing screenshot './ja/ipad_pro_3rd_gen_home_page.png' [10:45:47]: Added frame: '/Users/chenkaty/Documents/FaxGun/fastlane/screenshots/ja/ipad_pro_3rd_gen_home_page_framed.png' [✔] Framing screenshot './ja/iphone6Plus_1_home_page.png' [10:46:07]: Added frame: '/Users/chenkaty/Documents/FaxGun/fastlane/screenshots/ja/iphone6Plus_1_home_page_framed.png'
Environment
✅ fastlane environment ✅
Stack
| Key | Value |
|---|---|
| OS | 10.15 |
| Ruby | 2.5.0 |
| Bundler? | false |
| Git | git version 2.25.0 |
| Installation Source | ~/.rbenv/versions/2.5.0/bin/fastlane |
| Host | Mac OS X 10.15 (19A583) |
| Ruby Lib Dir | ~/.rbenv/versions/2.5.0/lib |
| OpenSSL Version | OpenSSL 1.0.2n 7 Dec 2017 |
| Is contained | false |
| Is homebrew | false |
| Is installed via Fabric.app | false |
| Xcode Path | /Applications/Xcode.app/Contents/Developer/ |
| Xcode Version | 11.3.1 |
System Locale
| Variable | Value | |
|---|---|---|
| LANG | en_US.UTF-8 | ✅ |
| LC_ALL | en_US.UTF-8 | ✅ |
| LANGUAGE |
fastlane files:
No Fastfile found
No Appfile found
fastlane gems
| Gem | Version | Update-Status |
|---|---|---|
| fastlane | 2.143.0 | ✅ Up-To-Date |
Loaded fastlane plugins:
No plugins Loaded
Loaded gems
| Gem | Version |
|---|---|
| did_you_mean | 1.2.0 |
| slack-notifier | 2.3.2 |
| atomos | 0.1.3 |
| colored2 | 3.1.2 |
| nanaimo | 0.2.6 |
| xcodeproj | 1.14.0 |
| rouge | 2.0.7 |
| xcpretty | 0.3.0 |
| terminal-notifier | 2.0.0 |
| terminal-table | 1.8.0 |
| plist | 3.5.0 |
| multipart-post | 2.0.0 |
| word_wrap | 1.0.0 |
| public_suffix | 2.0.5 |
| colored | 1.2 |
| highline | 1.7.10 |
| commander-fastlane | 4.4.6 |
| http-cookie | 1.0.3 |
| faraday-cookie_jar | 0.0.6 |
| faraday_middleware | 0.13.1 |
| gh_inspector | 1.1.3 |
| mini_magick | 4.9.5 |
| multi_xml | 0.6.0 |
| rubyzip | 1.3.0 |
| security | 0.1.3 |
| xcpretty-travis-formatter | 1.0.0 |
| bundler | 2.0.1 |
| naturally | 2.2.0 |
| simctl | 1.6.5 |
| jwt | 2.1.0 |
| uber | 0.1.0 |
| declarative | 0.0.10 |
| declarative-option | 0.1.0 |
| representable | 3.0.4 |
| retriable | 3.1.2 |
| mini_mime | 1.0.2 |
| httpclient | 2.8.3 |
| google-api-client | 0.36.4 |
| emoji_regex | 1.0.1 |
| jmespath | 1.4.0 |
| aws-eventstream | 1.0.3 |
| aws-sigv4 | 1.1.1 |
| aws-sdk-core | 2.11.460 |
| aws-sdk-resources | 2.11.460 |
| aws-sdk | 2.11.460 |
| CFPropertyList | 3.0.2 |
| claide | 1.0.3 |
| unicode-display_width | 1.6.0 |
| addressable | 2.7.0 |
| tty-screen | 0.7.0 |
| tty-cursor | 0.7.0 |
| tty-spinner | 0.9.1 |
| babosa | 1.0.3 |
| excon | 0.72.0 |
| faraday | 0.17.3 |
| unf_ext | 0.0.7.6 |
| unf | 0.1.4 |
| domain_name | 0.5.20190701 |
| fastimage | 2.1.7 |
| json | 2.2.0 |
| dotenv | 2.7.5 |
| multi_json | 1.14.1 |
| signet | 0.13.0 |
| os | 1.0.1 |
| memoist | 0.16.2 |
| googleauth | 0.11.0 |
| digest-crc | 0.4.1 |
| google-cloud-errors | 1.0.0 |
| google-cloud-env | 1.3.0 |
| google-cloud-core | 1.5.0 |
| google-cloud-storage | 1.25.1 |
| openssl | 2.1.0 |
| date | 1.0.0 |
| fileutils | 1.0.2 |
| ipaddr | 1.2.0 |
| psych | 3.0.2 |
generated on: 2020-03-07
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 1
- Comments: 19 (5 by maintainers)
Commits related to this issue
- fix(frameit) Prevent font to match if the screenshot name contains the language name When frameit tries to match fonts with screenshots, it looks in the screenshot path to see if the font supported l... — committed to thegrizzlylabs/fastlane by bvirlet 4 years ago
- fix(frameit) Prevent font to match if the screenshot name contains the language name (#16316) When frameit tries to match fonts with screenshots, it looks in the screenshot path to see if the font su... — committed to fastlane/fastlane by bvirlet 4 years ago
- fix(frameit) Prevent font to match if the screenshot name contains the language name (#16316) When frameit tries to match fonts with screenshots, it looks in the screenshot path to see if the font su... — committed to minuscorp/fastlane by bvirlet 4 years ago
I have reproduced the issue and have a fix for it. In the meantime, try to ensure your screenshot names do not have any language in them. In your case
iphone6Plus_3_track_framedcontainstr. Rename it in a different way and you should be good.