fastlane: [Fastlane.Swift] `onError` never called.
New Issue Checklist
- Updated fastlane to the latest version
- I read the Contribution Guidelines
- I read docs.fastlane.tools
- I searched for existing GitHub issues
Issue Description
Currently, the method onError isn’t implemented in LaneFileProtocol so that we can’t handle errors, for example during deliver.
If any lane fails, there is no way to handle the failure.
Command executed
Any lane, for example:
fastlane deliver
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 1
- Comments: 18 (2 by maintainers)
@andemengo we have a PR that you can checkout resolving this issue! 😄
You shouldn’t, but the socket must be running in order to just let the Swift part work. On the other hand is the lack of call of the on error callback, the logs of the socket should provide us the answer about why the callback is not getting called. I suspect that fastlane is not sending that specific error as an error in the socket message and hence the callback is not getting called, a simple sh call with an error callback seems to be working, so that’s why my suspect is on the socket side, could you provide the whole lot on submitting the application so I can review what if being sent in the socket? Also, I’d use the individual error callbacks of the Swift calls instead the global one and see if it works?
It seems to me also that you aren’t booting the fastlane socket manually… Maybe you’re forgetting that step
I’d love to see this working as well! @andemengo if you could open a PR to address this change, that’d be superb! ❤️