App: [Payment due June 23 2023 $1500] App crashing when sending mention with two underscores

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open staging.new.expensify.com
  2. Start a DM with someone
  3. Type a mention (e.g. @someone) to a chat with two underscores before and after the @ symbols like so:
  • Type mention: @concierge@expensify.com
  • Manually edit the mention to have underscores like so: @_concierge_@expensify.com
  1. Hit send on the manually edited mention

Expected Result:

App shouldn’t be crashing

Actual Result:

App crashed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.22.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/e1b98d23-f45b-4bd9-b57c-ba3d44c4c251

https://github.com/Expensify/App/assets/93399543/f7147b2d-2356-4e95-ac05-0d808f6b1701

Expensify/Expensify Issue URL:

Issue reported by: @kerupuksambel

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685210491228269

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0192a54b7fe00d88f1
  • Upwork Job ID: 1666449278662524928
  • Last Price Increase: 2023-06-07

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 42 (24 by maintainers)

Most upvoted comments

all paid.

@michaelhaxhiu I think this is due for the bonus. See the calculation below:

Screenshot 2023-06-15 at 8 55 48 PM

The PR to bump expensify-common version for App is waiting for the other https://github.com/Expensify/App/pull/20652 to merge to avoid conflicts.

cc @allroundexperts @johnmlee101

@eh2077 Can you go ahead and create your PR as well? If the other one gets merged first, we will just resolve conflicts on our end.

Thank you for your tip, looks much better now image

I added correctly, but when I saved it does not look good for reproduction.

image