App: [Payment due 3/6][$500] Font in "Hold Request" reason heading text is looks wrong

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.43-7 Reproducible in staging?: y Reproducible in production?: new feature If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708436683366409

Action Performed:

Create a IOU request
Open the IOU details and click on 3 dot and select “Hold request” option
Look at the Explain why you're holding this request

Expected Result:

Should match with same font in other section like display name

Actual Result:

It shows with different font.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence Screen Shot 2024-02-21 at 12 50 00 PM

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017627c882f3450aea
Upwork Job ID: 1760361321264185344
Last Price Increase: 2024-02-21
Automatic offers:

s77rt | Reviewer | 0
shahinyan11 | Contributor | 0

About this issue

Original URL
State: closed
Created 4 months ago
Comments: 25 (16 by maintainers)

Most upvoted comments

it sounds like we’re simply removing the textheadline style from the text to match that of the display name message (which has none)

That’s correct! It should end up looking something like this CleanShot 2024-02-23 at 08 12 31@2x

dannymcclain on Feb 23, 2024

No worries @hayata-suenaga , let him do it, he rightly proposed earlier than me

hey @shahinyan11 , you can try using styles.textHeadlineLineHeightXXL over here rather than removing the heading style altogether, we already use it in business info step:

I think you should talk with the design team once before implementing this, best luck with the PR 😃

codinggeek2023 on Feb 22, 2024

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/33897
The offending PR has been commented on: https://github.com/Expensify/App/pull/33897#discussion_r1515277961
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No, this kind of bug is not something that’s likely to resurface

s77rt on Mar 6, 2024

payment should be issued after the regression period is over

hayata-suenaga on Mar 4, 2024

Thanks @codinggeek2023 !

cc: @Expensify/design for a quick sanity check (👍 / 👎 ). Based on the Slack discussion it sounds like we’re simply removing the textheadline style from the text to match that of the display name message (which has none)?

robertjchen on Feb 23, 2024

@codinggeek2023 No worries. I didn’t imply that you copied the solution 😅. I checked the timeline both solutions posted closely at the same time (2 mins apart).

s77rt on Feb 21, 2024