App: [Pay Aug 18 if no regressions] Copy to clipboard - Unable to copy images or links

Thanks @aliabbasmalik8, but I think we’re going to move forward with @Drewfergusson on this issue for now. @puneetlath Will you please hire @Drewfergusson on Upwork?

Yeah, as stated in this comment and the previous one, @Drewfergusson only worked on the portion of this issue related to copying links, but he also set up a really easily extensible framework to display different types of context menus depending on what was interacted with.

So we need to follow-up on this issue with part 2. I created a separate issue over here: https://github.com/Expensify/App/issues/4629

Hey, @puneetlath @roryabraham I was working on testing the solution I came up with and ran into an issue with what I proposed.

In my proposal, I am essentially creating a reusable component to wrap some “thing” (in this case the link) with a react native Pressable component . This special Pressable then triggers a Popover. This works fine on browser, desktop, and mobile web. (PR here)

For mobile though, links at their core have a Text element with an onPress attribute. It seems that on mobile, events are not propagating out as they do in a browser normally. (or something is preventing this that I don’t know of). If I remove the onPress attribute from the Text component, wrapping it with the special Pressable I created works fine. As soon as I add back the onPress attribute then wrapping does not propagate onPress nor onLongPress events. It seems like the same Text component or Pressable component will have to have to have the onLongPress and on onPress attributes. It will not be as cleanly composable as I first thought.

Still working on a nice solution on the mobile side and should have an update soon. Let me know if anything comes to mind.

@puneetlath I submitted my proposal with the name Andrew Michael Ferguson. It was a couple of days ago so you may have to look. Not sure if this link works for you but this is the link where I can view my proposal. https://www.upwork.com/ab/proposals/1409996432714612737

Hm, @roryabraham @iwiznia @parasharrajat I think a few different issues are being conflated here. The original issue reported here was that when you copy a message that contains an image, it puts the raw html on your clipboard instead of just the image. This also was happening with messages that contained links, but isn’t anymore (I had already removed @isagoico’s screenshot that showed it).

I think we should split up what y’all are saying into separate issues and implement it slightly differently.

1. When a message contains an image and is copied (either by hovering the message and choosing the “copy to clipboard” option or by right-clicking/long-pressing) copy the image itself. We can do this for messages that contain images since we don’t support messages that have images + text. Any image input is only the image. (this issue)
2. When a url is right-clicked/long-pressed select the text of the url. This will make it so that we only copy the URL since we already support copying only selected text. This would match the behavior I expect when using a typical web page and right clicking a URL. (separate issue)

That’s how I’d implement this. And I’d do it in two different issues. What do y’all think?

I think that’s not what the issue meant.

Try this is a message with link https://google.com Now try to copy the link only.

Hm, it’s working for me on desktop on staging for links.