App: [Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js
Held on https://github.com/Expensify/App/issues/34613
This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: NewDistanceRequestPage
New Component IOURequestStepDistance
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase
- Look at the history of the Old Component
- If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
- Replace all uses of the Old Component with the New Component
- Remove all traces of Old Component
- Be sure to update all routes and navigation to use the new
:actionparam (instead of being hard-coded with"create") - Update any logic like
isEditingto use the new action param from the route
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f10eeacf3fc8d218
- Upwork Job ID: 1747632624829898752
- Last Price Increase: 2024-01-17
- Automatic offers:
- cubuspl42 | Reviewer | 28115391
- DylanDylann | Contributor | 28115392
About this issue
- Original URL
- State: open
- Created 5 months ago
- Comments: 44 (31 by maintainers)
Posted on Slack to clear: https://expensify.slack.com/archives/C01GTK53T8Q/p1705999852089949
Anyway, we indeed need to re-open this.
We’re working on two of the regressions:
Please don’t tell me this is because this part…
…triggered the auto-closing regex 😭
@cubuspl42 I fixed this issue and trying to find the best solution for this issue
@DylanDylann
NewDistanceRequestPageIOURequestStepDistancewith changes and fixes that were applied toNewDistanceRequestPage(all that apply)IOURequestStepDistance).This is clear from our issue description.
So the actual question is whether
EditRequestDistancePagebelongs to the Old Component set, right?