App: [Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js

Held on https://github.com/Expensify/App/issues/34613

This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: NewDistanceRequestPage New Component IOURequestStepDistance

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

  1. Look at the history of the Old Component
  2. If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
  3. Replace all uses of the Old Component with the New Component
  4. Remove all traces of Old Component
  5. Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
  6. Update any logic like isEditing to use the new action param from the route
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f10eeacf3fc8d218
  • Upwork Job ID: 1747632624829898752
  • Last Price Increase: 2024-01-17
  • Automatic offers:
    • cubuspl42 | Reviewer | 28115391
    • DylanDylann | Contributor | 28115392

About this issue

  • Original URL
  • State: open
  • Created 5 months ago
  • Comments: 44 (31 by maintainers)

Most upvoted comments

Anyway, we indeed need to re-open this.

We’re working on two of the regressions:

Please don’t tell me this is because this part…

[...] which intended to fix https://github.com/Expensify/App/issues/34610

…triggered the auto-closing regex 😭

@cubuspl42 I fixed this issue and trying to find the best solution for this issue

@DylanDylann

  • We definitely need to remove NewDistanceRequestPage
  • We need to update the IOURequestStepDistance with changes and fixes that were applied to NewDistanceRequestPage (all that apply)
  • As I understand it, we should replace all references to the Old Components with the appropriate references to the New Component (IOURequestStepDistance).

This is clear from our issue description.

So the actual question is whether EditRequestDistancePage belongs to the Old Component set, right?