App: Incorrect page is showing even there is error in bank connect flow
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Start connect bank flow, do everything till step 3 fine, Save and continue.
- Close the modal & open the flow again by click
Continue with the step. - Observe you’re landed and Step 3 which is correct, now navigate back to 2nd step and do type random invalid email which returns backend error.https://hahjajhahjahja.assssss.a.s.s.ss.a.s.ssssssass.asssshja.chjahjahahjhjajhha.hjahjahjahjahjahjahja.hahjahjjahjahjaahjahjhja.hjahjahjahjaahjahj.hjahjahjahjahjaahjahj.hjahjahjahjaahj.hjajhahjaajhahjahjahjahjahjahjahjahjahjahjaahjahjaasshjsjhshjsh/jshjshj.chjahjshjshjshjshjshj.hjahjahshjshjshjshjshjshjshjshjshjs.ahjshjshjshjshjshjshjs.hjahjahjshjshjshjshjshjshjshjhjshjshjshjshjshjshjshjshjshjshjhjshjshjahj.com/
- Observe that data save failed & you’re stuck at step.
- Close the modal & restart the flow again by click
Continue Over stepand observe it takes to step 3 instead of step 2
Expected Result:
Flow should be take us to the correct step if any failed validations there when updating.
Actual Result:
Taking to the wrong page even having wrong details.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.53-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/d1a26291-0954-41c1-a0ec-6e067cf1a086
https://github.com/Expensify/App/assets/43996225/e03af070-bd5c-4333-99f4-b464e74ffda1
Expensify/Expensify Issue URL: Issue reported by: @b4s36t4 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690924062828829
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01cf0cacf8a882b35c
- Upwork Job ID: 1690903425450983424
- Last Price Increase: 2023-08-28
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 46 (34 by maintainers)
@jliexpensify I’d agree with this assessment
@daordonez11 If we send a pusher event to the frontend with the correct
achDatastep after a server validation fails, I don’t think we would need to do any further thing on the frontend. I think this should be fully internal. @jliexpensify Can you ask someone from the internal team to please review this?Ok, awesome - thanks @daordonez11! @allroundexperts could you review this comment and share your thoughts on whether this needs to be brought internally? It sounds like it could go either way. Thanks!
@jliexpensify basically in the steps of the ticket mentioned what is discussed is about the information that is in the form but they say that since it hasn’t been validated there is nothing to do. The difference with this ticket is that here it is validated, it does fail when you try to save and continue(Step 4), hence, the server should be able to store the “failed” step. That is the difference between both tickets. So probably this might be half internal because achData is stored in the server but since we know in the front-end something failed in the form the server should update that as well.
cc @hungvu193 Let me know if I missed something else