App: [HOLD][$250] Dev - Getting console warning in android

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

build the app
immediately see the errors

Expected Result:

No console warnings displayed

Actual Result:

Console warnings about keyboardAvoidingViewBehavior are present

Workaround:

Unknown

Platform:

Where is this issue occurring?

Android

Version Number: 1.2.12-3 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: 2022-10-11_11-14-40 2022-10-11_11-14-48

Expensify/Expensify Issue URL: Issue reported by: @aneequeahmad Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665522948008369

View all open jobs on GitHub

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 42 (38 by maintainers)

Most upvoted comments

Yep we can close this now. Thanks @aimane-chnaif.

Luke9389 on Nov 17, 2022

I vote we close this issue as it’s not a big problem and will be fixed after https://github.com/Expensify/App/pull/10648

thesahindia on Oct 12, 2022

Paid!

MitchExpensify on Nov 18, 2022

Looks fair to me @aneequeahmad! Added you as a reporter

MitchExpensify on Oct 27, 2022

I think i should also be added in reporter as I reported this bug on 1st September here and again same error on another component on 28th September here. Thanks

cc: @kavimuru, @MitchExpensify, @Luke9389

aneequeahmad on Oct 27, 2022

Ok, I checked again. It will indeed cause that issue. I retract my decision. I like the suggestion from @hungvu193 in https://github.com/Expensify/App/issues/11733#issuecomment-1277010019 to add enable/disable behavior but there is another PR that is trying to change this code so it might be needed.

These are two options here.

Either we refactor the code following our guidelines and add enable/disable functionality.https://github.com/Expensify/App/issues/11733#issuecomment-1277010019
Just fix the warning. https://github.com/Expensify/App/issues/11733#issuecomment-1275546645

Setting keyboardAvoidingViewBehavior prop to '' or undefined has same effect as disabling the KeyboardAvoidingView.

In both ways, @hungvu193 proposals make sense.

cc: @Luke9389 what do you think we should do?

IMO, let’s just focus on point 2 as the issue says. There are some ongoing efforts in different PR/issues which will affect the KeyboardAvoidingView behavior.

🎀 👀 🎀 C+ reviewed

parasharrajat on Oct 13, 2022

If we can fix this now it is fine to just do it.

marcaaron on Oct 12, 2022