App: [HOLD for payment 2024-04-09] [$500] [Remove Free Workspace Creation] Update Workspace Creation in NewDot to Create Collect Workspaces
- Held on https://github.com/Expensify/App/issues/37149 so that the new notifications are in place on the server
- Held on https://github.com/Expensify/App/issues/37151 so that all collect policies created in NewDot are accessible in NewDot
- Should be coordinated to be released along with https://github.com/Expensify/App/issues/37151
This will make sure that any workspace created from NewDot is a collect workspace and not a free workspace.
- Change
CONST.POLICY.TYPE.FREEtoCONST.POLICY.TYPE.TEAMhere, here, and here - Update tests in SidebarFilterTest and PolicyTest to use
CONST.POLICY.TYPE.TEAM
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~016d89cd1132beada5
- Upwork Job ID: 1762127738310324224
- Last Price Increase: 2024-03-06
- Automatic offers:
- GandalfGwaihir | Contributor | 0
About this issue
- Original URL
- State: closed
- Created 4 months ago
- Comments: 33 (15 by maintainers)
@slafortune This was a new feature and as such, a checklist is not needed here. We can add the following regression test though:
+icon in the LHN.Create new workspace.Do we 👍 or 👎 ?
PR was on hold for another
BEPR, this should be merged by Tomorrow 😃 thanks @slafortuneLooks like we are waiting on 38191 to be merged 👍
@GandalfGwaihir’s proposal works well!
🎀 👀 🎀 C+ reviewed
This is off HOLD
@slafortune I think @tgolen has pretty much shared all the pieces that are needed in the issue description. @godofoutcasts94’s proposal is essentially a duplicate of what @codinggeek2023 proposed earlier. But even that proposal is just a duplicate of what @tgolen said here. I think we need a better proposal that has at-least a working demo.