App: [HOLD for payment 2024-04-09] [$500] [Held requests] show status on distance requests

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Coming from the discussion here: https://github.com/Expensify/App/pull/37121#issuecomment-1965819951

Update display of status on distance requests to show state (Approved/Pending/Canceled/Hold) like we do for Cash expenses.

Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1710439388757009

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Create a distance request
  4. Go to request details page
  5. Click 3-dot menu > Hold request
  6. Add a reason and save it

Expected Result:

Distance expense request should show Hold

Actual Result:

Distance expense request does not show any status

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e3e32c45e45f949f
  • Upwork Job ID: 1769963579385311232
  • Last Price Increase: 2024-03-19
  • Automatic offers:
    • situchan | Reviewer | 0
    • ShridharGoel | Contributor | 0

About this issue

  • Original URL
  • State: closed
  • Created 4 months ago
  • Comments: 56 (44 by maintainers)

Most upvoted comments

@situchan , nothing much from my side, we can proceed as they were the first to dibs 😃

@rayane-djouah it was discussed already. If you have any doubt, please ask in slack thread.

Sounds good. Thanks

We got answer. It should be consistent. Let’s fix this to show status on all type of requests.

oh it seems no discussion happened. Please assign me here. I will raise discussion on slack.