App: [HOLD for payment 2024-04-05] [$500] When editing a message with `<div>`, it becomes `` If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.54-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710750972703159
Action Performed:
- Send a message
<div>
- Hover or long press on this message
- Choose edit message
Expected Result:
The draft edit message remains as is
Actual Result:
The draft message suddenly becomes <div>
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/54d80073-6834-42d9-9951-f6fd5ce81497
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~010257a39eea7eb507
- Upwork Job ID: 1769863831107096576
- Last Price Increase: 2024-03-18
- Automatic offers:
- dukenv0307 | Contributor | 0
- tienifr | Contributor | 0
About this issue
- Original URL
- State: closed
- Created 3 months ago
- Comments: 34 (19 by maintainers)
Most upvoted comments
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.54-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @dukenv0307 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710750972703159
Action Performed:
- Send a message
<div> - Hover or long press on this message
- Choose edit message
Expected Result:
The draft edit message remains as is
Actual Result:
The draft message suddenly becomes <div>
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/54d80073-6834-42d9-9951-f6fd5ce81497
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~010257a39eea7eb507
- Upwork Job ID: 1769863831107096576
- Last Price Increase: 2024-03-18
- Automatic offers:
- dukenv0307 | Contributor | 0
- tienifr | Contributor | 0
About this issue
- Original URL
- State: closed
- Created 3 months ago
- Comments: 34 (19 by maintainers)
Let’s go with @tienifr’s alternative solution. Currently, we’re saving the draft value of main composer as its original form so we should do the same with edit composer
🎀👀🎀 C+ reviewed
BugZero Checklist:
Regression test:
<div>or any markdown text (*bolded text*, …)Do we 👍 or 👎
@twisterdotcom No problem, I’m a new C+ so I’m not sure about this case. I’ll try to volunteer before the issue is external
Ah @dukenv0307 yeah sorry, I didn’t see this in Slack so I just left it with @aimane-chnaif sorry. Let’s leave it for now, if @aimane-chnaif needs to hand it off for any reason, I’ll make sure it goes to you.
Lots of proposals to go at here anyway @aimane-chnaif!
I already started investigating this issue. @dukenv0307 you should have volunteered earlier before making External which auto-assigns C+.