App: [HOLD for payment 2024-04-05] [$500] [Simplified Collect][Members] Changing owner: Full flow implementation

Implement Changing owner: Full flow implementation from the Simplified Collect: Profile, Members, Categories design doc

Issue OwnerCurrent Issue Owner: @burczu
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01289ff00d54fea22e
  • Upwork Job ID: 1755658801369747456
  • Last Price Increase: 2024-02-08

About this issue

  • Original URL
  • State: closed
  • Created 5 months ago
  • Comments: 47 (31 by maintainers)

Most upvoted comments

No need to add tests here. We’re adding it as part of the project - https://github.com/Expensify/Expensify/issues/383378

I think @burczu is out for the day already. We’re discussing this 1:1 since there are a lot of different pages/steps to cover.

Daily update: today I was mostly busy addressing some regressions from my previous PR, but in this issue I was able to make some changes to allow pressing on the row in the Members list while preventing from pressing the checkbox at the same time (this is necessary for some constraints in bulk actions - discussed this with @luacmartins today). I’ve also added the Transfer owner option visible for admins that are not owners, when they open owner’s details. From this state I’ll be able to add next steps of the change owner flow.

Daily update: I’ve created pages for all the change ownership confirmations and partially for the add payment card form - I think the core functionality for this feature should be done tomorrow.

@CortneyOfstad @adelekennedy @luacmartins As the blocking issue has the PR ready for review, I’m starting the implementation of this issue (while addressing potential feedback for the PR, of course) - I think we can remove ON HOLD here and switch to Daily.

I’ll create the new branch on top of the branch I’ve used for https://github.com/Expensify/App/issues/35715 implementation, so I think the most reasonable will be that I’ll post the draft PR once the other PR is merged - then, only changes related to this issue will be visible there. Is it ok?

@CortneyOfstad I haven’t started the implementation yet of both https://github.com/Expensify/App/issues/35715 and this one - I’ll let you know once I start working on this issue. Switching to Weekly for now may be a good idea because I don’t think I’ll start this week.