App: [HOLD for payment 2024-03-26] [$500] Clean up the `PersonalDetails` type

The issue was noticed during Report TS migration PR review.

Problem

During Task creation from a message, the code uses assignee.assigneeChatReport where the assignee has PersonalDetails type. But assigneeChatReport is always undefined in this case cause it doesn’t exist in the assignee. It also leads to unnecessary field assigneeChatReport in the PersonalDetails type. https://github.com/Expensify/App/blob/da7697734c1f759786eba0a643a062b4e39a47ad/src/pages/home/report/ReportFooter.tsx#L98-L102

Solution

  1. Get rid of non-existing assignee.assigneeChatReport usage.
  2. Remove assigneeChatReport field from PersonalDetails type.
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012dff61fb5ff367d3
  • Upwork Job ID: 1767670780339933184
  • Last Price Increase: 2024-03-12
Issue OwnerCurrent Issue Owner: @MitchExpensify

About this issue

  • Original URL
  • State: closed
  • Created 4 months ago
  • Comments: 15 (8 by maintainers)

Most upvoted comments

Paid and contract ended - Did you receive @cubuspl42 ?

Payment summary:

C+: $500 cubuspl42 (Upwork)