App: [HOLD for payment 2024-03-26] [$250] Remove MoneyRequestSelectorPage.js and copy any changes since Nov 27 into IOURequestStartPage.js
This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: MoneyRequestSelectorPage
New Component IOURequestStartPage
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase
- Look at the history of the Old Component
- If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
- Replace all uses of the Old Component with the New Component
- Remove all traces of Old Component
- Be sure to update all routes and navigation to use the new
:actionparam (instead of being hard-coded with"create") - Update any logic like
isEditingto use the new action param from the route
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~011477b63464907ecf
- Upwork Job ID: 1747632909135507456
- Last Price Increase: 2024-01-17
- Automatic offers:
- hoangzinh | Reviewer | 28117811
- Krishna2323 | Contributor | 28117812
Issue Owner
Current Issue Owner: @garrettmknightAbout this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 53 (36 by maintainers)
@trjExpensify just reassigning in case this needs help while I’m OOO this week thought it probably won’t - will be back 2/21 to pick it back up.
This has been reviewed, merged and deployed to staging.
awaiting @neil-marcellini to do the final review round
Final final discussion 😆
@hoangzinh, will raise a PR tomorrow, I already tried multiple times today in the morning. Don’t have time now because its a little complicated and will take some time.
@Krishna2323 Please pull the latest main and try again. It seems this bug is fixed.