App: [HOLD for payment 2024-02-20] [$500] Command + left/right arrow to go back/forward stopped working on desktop

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.35-5 Reproducible in staging?: yes Reproducible in production?: yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @rafecolton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706724719541289

Action Performed:

Open RHP in desktop app
Use cmd + left/right arrow

Expected Result:

Able to navigate between screens

Actual Result:

nothing happens

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/1a29edd5-e66b-4a49-b1a6-91320d31ef93

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017be8ae464b81915b
Upwork Job ID: 1753269207737479168
Last Price Increase: 2024-02-02
Automatic offers:

akinwale | Reviewer | 28143786
bernhardoj | Contributor | 28143787

Most upvoted comments

PR is ready

cc: @akinwale

bernhardoj on Feb 6, 2024

@rafecolton In that case, I suppose it makes sense to implement support for new shortcuts instead of replacing the existing ones.

@bernhardoj Could you update your proposal to take this approach?

akinwale on Feb 2, 2024

[@akinwale] The PR that introduced the bug has been identified. Link to the PR:

[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. This functionality was not implemented for desktop.

[@akinwale] Determine if we should create a regression test for this bug.

[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Launch the desktop app.
Open any number of chat reports.
Press Cmd+Left arrow key on the keyboard (make sure no text input is focused and no modal is open before pressing the keys).
Verify that the app navigates back.
Press Cmd+Right arrow key on the keyboard (make sure no text input is focused and no modal is open before pressing the keys).
Verify that the app navigates forward.

Do we agree 👍 or 👎?

akinwale on Feb 21, 2024

@bernhardoj, we can move forward with the proposal. Thanks!

isabelastisser on Feb 6, 2024

@isabelastisser Yes, we can move forward with @bernhardoj’s proposal.

🎀👀🎀 C+ reviewed.

akinwale on Feb 5, 2024

@akinwale I don’t agree that we should close this. Using cmd + arrow keys is pretty universal back/forward behavior across many apps, including Slack and Google Chrome. It also works in Safari.

rafecolton on Feb 2, 2024

Looking at the official Apple Safari shortcuts (assuming this is the intended behaviour we want to emulate here) under History, Cmd+] and Cmd+[ are the keyboard shortcuts to navigate forward and back respectively, so I think we can close this one.