App: [HOLD for payment 2024-02-20] [$250] [Wave 8] [Ideal Nav] Workspace Switcher Icon: Missing tool tip and wrong icon color
Action Performed:
- On a browser, hover over the Workspace Switcher icon (the avatar-like icon at the top-left color of the new Left Hand Pane (see the video).
Expected Result:
There should be a tooltip that displays Choose a workspace.
Only the background of the chevron icon should change, not the fill color of the chevron icon.
Please also read Shawn (our designer)'s additional comment here
Actual Result:
The tooltip doesn’t appear. The fill color of the chevron icon on hover changes on hover…
Workaround:
N/A
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
https://github.com/Expensify/App/assets/98560306/77efe29e-a48a-442a-adef-57db3de62c89
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01566d00a9005cba1a
- Upwork Job ID: 1753450501284016128
- Last Price Increase: 2024-02-02
- Automatic offers:
- dukenv0307 | Contributor | 28141432
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 27 (17 by maintainers)
Also, want to clarify that for the small button over the workspace icon, just the button BG should be changing, not the icon color. We should be following our default button styles here.
We don’t need a specific test for this.
@thesahindia The PR is ready for review.
Hmm I would think the tool tip should actually say “Choose a workspace” since tapping this element takes you to that flow of the app. cc @trjExpensify @Expensify/design for a gut check there though.
hi! Sorry I’m ooo sick today - I’ll follow up on this tomorrow
We generally handle these things in the PR. The issue is minor and the first proposal was good enough.
Yup, I also agree with that.
Totally agree.