App: [HOLD for payment 2024-01-24] [$500] Android - Request-Wrong error message appears when tryin to choose `my location` for start and finish
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.11-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
- Open the App
- Login with any account
- Go to FAB -> Request money -> Distance
- Choose my location for start and finish points
Expected Result:
There should not be an error message, only when you later create a request, an error appears that you need to select different addresses
Actual Result:
An error message appears if choose as Finish point my location if `my location was chosen as Start point before
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/82ef7898-2f6f-466b-b5e1-f8ec3d2ad76c
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~019bd90e7731b4b6c6
- Upwork Job ID: 1737972831436316672
- Last Price Increase: 2023-12-28
Issue Owner
Current Issue Owner: @saklugerAbout this issue
- Original URL
- State: closed
- Created 7 months ago
- Comments: 45 (24 by maintainers)
Most upvoted comments
- The PR that introduced the bug has been identified. Link to the PR: there isn’t a PR that introduced this bug, we’re just changing the config value to allow for poor GPS connection
- The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
- A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: additional discussion isn’t needed, this is an extreme edge case
- Determine if we should create a regression test for this bug. It’s hard to reliably simulate a poor GPS connection on Android (I’ve had to use a basement), I don’t think QA team would be able to do that