App: [HOLD for payment 2024-01-22] HIGH: (Comment linking: step 1) 'maintainVisibleContentPosition' doesn't works with the large list
Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
Action Performed:
Case 1 (correct)
- Create a list with the 50 elements. You can use Report Actions for items
- Set to FlatList:
maintainVisibleContentPosition={{
minIndexForVisible: 0,
}}
- Using
onStartReachedadd 50 items
Case 2 (wrong)
- Create a list with the 50 elements. You can use Report Actions for items
- Set to FlatList:
maintainVisibleContentPosition={{
minIndexForVisible: 0,
}}
- Using
onStartReachedadd 100 items
Expected Result:
In the both cases, you won’t see any changes after adding new items, so the reportActions don’t move in the viewport
Actual Result:
- In the first case, you won’t see any changes after adding new items, so the reportActions don’t move in the viewport
- In the second case, you would see slides after adding new elements to FlatList.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
EXPO snack: https://snack.expo.dev/@tarasperun/add-items-onsatartreached
https://github.com/Expensify/App/assets/48593211/76c9f2f0-f1eb-4fd9-9895-d7526ce7b8a1
About this issue
- Original URL
- State: closed
- Created 7 months ago
- Comments: 24 (18 by maintainers)
yes
I may take responsible for BZ Checklist since I reviewed PR
I think we can skip checklist here. No regression. The bug was in upstream. Not able to catch in E/App until comment linking is live.
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
It was reviewed and approved
Nothing for you to work on for now @isabelastisser – I’ll let you know if any payments need to be issued
Update: found the problem, opened a PR to fix upstream, will patch in Expensify app next and verify the fix. https://github.com/facebook/react-native/pull/41846
@roryabraham mentioned you to be aware of this bug, which we are currently tackling