App: [HOLD for payment 2024-01-17] [$500] HIGH: Improve formatting of People in this workspace can find your room message

@mallenexpensify ^

https://github.com/Expensify/App/issues/32614#issuecomment-1895923583 is false positive

Actually I’ll comment in the other thread.

Thanks for assigning me! The PR is here: https://github.com/Expensify/App/pull/33717#issuecomment-1871369253

cc @s77rt

Appreciate all the discussion here @tienifr @esh-g @s77rt ! 🙇 Having reviewed everything that has transpired, I’m inclined to agree with @s77rt 's conclusion here: https://github.com/Expensify/App/issues/32614#issuecomment-1868481620

Given that the follow-on changes and feedback to @esh-g 's proposal were not critical for proposal selection, their initial proposal would’ve qualified. Let’s move forward here 👍

@quinthar I’m not waiting on the design input myself. @shawnborton is suggesting to change the current selection list design to match the mock up (the mock up that was originally designed for the selection list in general and not just the one above for the visibility selector). This is not a blocker though. We are waiting for @robertjchen review on https://github.com/Expensify/App/issues/32614#issuecomment-1854416404.

@tienifr to be fair and to address https://github.com/Expensify/App/issues/32614#issuecomment-1859503674 I think the timeline is as follow:

1. @esh-g Fixed the missing alternateText in ValueSelectorModal
2. You added to that solution moving the “People in this workspace can find your room” message to the MenuItem component using a new prop
3. @esh-g added to your solution that we can move the message without using a new prop but an existing one

The 2->3 change is indeed not important and not a critical factor for proposal selection. But the 1->2 change is also not much valuable as it’s pretty obvious since adding a text line to a component is pretty straightforward.

Even if we went with the 1st proposal from @esh-g we won’t miss a thing. For that reasoning I think it’s fair to go with @esh-g’s proposal

I hope that clarifies it. If you think I’m missing something here please create a Slack thread and tag me there. Let’s keep GH for proposals only. I would really appreciate your collaboration here.

• Title for all normal list items is bold (as proposed in my proposal)

• We are using the 13px textSupporting style already for the value picker https://github.com/Expensify/App/blob/4239252d5ace1039fa2aaf8d707f4e5de8523309/src/components/SelectionList/BaseListItem.js#L95

So, I would say that lines up with the expectations cc @robertjchen

The feedback I have for that is that:

• the titles of all select list options should be bold and in our normal text color
• the subtitle/description text for all select list options should use our 13px font size (label) and our textSupporting color

We should make those changes globally to all of these select list options. cc @Expensify/design for the gut check

@s77rt please review @esh-g 's proposal above, thx

@mallenexpensify I see you assigned yourself; can you clean this up and get a contributor on it?