App: [HOLD for payment 2024-01-11] [$500] [Wave 6: Workspace Chats] Submit button on expense view should not be green Collect workspaces

Related Slack chat: https://expensify.slack.com/archives/C02MW39LT9N/p1703187255250009?thread_ts=1703187017.215259&cid=C02MW39LT9N

Action Performed:

Pre-testing requirement: Collect workspace type with the isPolicyExpenseChatEnabled NVP set (SO).

Note: Scheduled submit should be set to any frequency other than Manually

  1. Sign-in for the first time using the member account • Verify that you land in the workspace chat
  2. Go to global create (+) > Request money > enter an amount > confirm
  3. Tap the report preview component to navigate to the expense report view • Verify that a banner is in the page header with the label Next steps ✅ • Verify that the next steps text matches the scheduled submit cadence you set on the paid policy. E.g “These expenses are scheduled to submit on Sunday. No action required.” ✅ • Verify that a dark blue Submit button is in the page header beneath the “Next steps” banner ❌

Expected Result:

Submit button in the expense report view should be the standard dark blue button colour - indicating it can’t be actioned

Actual Result:

Submit button in the expense report view is also green indicating it can be actioned

image

POLISH:

After hitting submit the next steps banner disappears and takes a while to reappear with the correct message.

Action step:

  1. Tap the Submit button • Verify the text in the next steps banner updates to reflect the report has been submitted and is awaiting approval: “Waiting for %approverName% to review these requests” ❌ • Verify a system message is added to the expense report from the submitter that reads: “submitted %reportTotal%” ✅

https://github.com/Expensify/App/assets/51066321/dd9a169d-0cfa-4630-954a-bdef93d35914

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0194651512192b0478
  • Upwork Job ID: 1737950405980835840
  • Last Price Increase: 2023-12-21
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

About this issue

  • Original URL
  • State: closed
  • Created 6 months ago
  • Comments: 30 (21 by maintainers)

Most upvoted comments

Sorry @abzokhattab This PR was taken internal