App: [HOLD for payment 2023-10-09] [$500] Dev: Web- Console error show when open room name page
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Create a WS
- Create a room
- Click the header of the room => Settings => Room bane
- Observe that an error appears in the console
Expected Result:
No console error
Actual Result:
An error appears in the console: “The prop isFocused is marked as required in RoomNameInput, but its value is undefined.”
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: Dev 1.3.70.4 Reproducible in staging?: n Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/465a8992-8cf0-482e-9903-a93c0e16fc6f
Expensify/Expensify Issue URL: Issue reported by: @namhihi237 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694920701405659
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d4b07b55c8e2063a
- Upwork Job ID: 1703792802906148864
- Last Price Increase: 2023-09-18
- Automatic offers:
- aimane-chnaif | Reviewer | 26875262
- namhihi237 | Contributor | 26875264
- namhihi237 | Reporter | 26875266
About this issue
- Original URL
- State: closed
- Created 9 months ago
- Comments: 33 (19 by maintainers)
@saranshbalyan-1234 I meant your main solution.
That prop is added specifically to fix iOS autofocus issue on new room tab while implementing TabNavigator. This doesn’t affect edit room page. So either solution is fine - pass
isFocusedto false oruseIsFocused. They’re not affected anything.I accepted @namhihi237’s solution just because they’re the first to provide root cause and working solution.
Is everything clear now?
Looks like this is ready for payment @peterdbarkerUK
@namhihi237’s proposal looks good to me. 🎀 👀 🎀 C+ reviewed
This is still reproducible. Reviewing shortly
Hello @peterdbarkerUK! QA team can only verify the bug on staging and production.