App: [HOLD for payment 2023-10-09] [$500] After Logout, using CMD + J only generates 2 shortcuts in the pop-up (instead of the full list)

I agree with holding this; the result will be better after merging the PR on #26809.

@Charan-hs - paying now. For future reference, there’s no need to submit work for review. Thanks!

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• [@ntdiary] Determine if we should create a regression test for this bug. No need
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Not a regression, just a tiny feature polish, don’t need a regression test. : )

🎯 ⚡️ Woah @ntdiary / @Charan-hs, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @Charan-hs got assigned: 2023-09-23 01:48:12 Z
• when the PR got merged: 2023-09-27 00:21:41 UTC

On to the next one 🚀

I don’t know why I was auto-assigned to the PR 🤔

@jasperhuangg I unassigned myself and assigned you as the reviewer of the PR 🙇

📣 @Charan-hs 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

📣 @Charan-hs 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

Their proposal makes sense to me! Assigned

@Charan-hs it’ll be @jasperhuangg who assigns you, not me!

@Charan-hs’s proposal makes sense to me, I think we can move forward with their proposal. : )

🎀 👀 🎀 C+ reviewed

Hi, @Charan-hs, perhaps we can just use delete documentedShortcuts[displayName]. Also, some small questions:

• When subscribing a key, adding documentedShortcuts is conditional, so when unsubscribing, should we consider this condition?
• The value of eventHandlers[displayName] is array, do we need to distinguish who added the value to documentedShortcuts?

FYI, It seems that using just delete documentedShortcuts[displayName] works well too.

@jliexpensify this PR https://github.com/Expensify/App/pull/26809 is merged and deployed.

I think this is a call for @ntdiary and @mollfpr to make!

@ishpaul777 Thank you for bringing this to our attention. However, I would like to inform you that this issue is already being addressed and worked on at the moment.https://github.com/Expensify/App/issues/25448

Proposal by @Charan-hs

Please re-state the problem that we are trying to solve in this issue.

All keyboard shortcut shows up in modal after Logout

What is the root cause of that problem?

When we are logged in or logged out we are unsubscribing the event handlers here. https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/libs/KeyboardShortcut/index.js#L83-L87 but When unsubscribing, we remove event listeners but not shortcuts from the variable documentedShortcuts. Even though I have unsubscribed, the shortcuts are still present in documentedShortcuts.

What changes do you think we should make in order to solve the problem?

Here, https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/libs/KeyboardShortcut/index.js#L83-L87 When unsubscribed we can remove the values present in documentedShortcuts by displayname (key).

    lodashUnset(documentedShortcuts,displayName);
//or
    documentedShortcuts = _.omit(documentedShortcuts,displayName);
//or
   documentedShortcuts[displayName] = {} // here we can return null or {}
//We can use the delete method also based on your request.

What alternative solutions did you explore? (Optional)