App: [HOLD for payment 2023-10-02] [$500] "Intro to your school principal" page is accessible with a public email

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sign-up with a public domain
  2. Go to https://staging.new.expensify.com/save-the-world/intro-school-principal (or /teachersunite/intro-school-principal after this PR is merged).

Expected Result:

  1. The user should be redirected to the page Update your email address (which is the page i-am-a-teacher).

Actual Result:

  1. The page “Intro to your school principal” is shown

Workaround:

Navigate to the other page, which should happen automatically

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

https://github.com/Expensify/App/assets/6829422/2e20556f-581d-4c6d-afc7-b1a92c4aaa15

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019ebe462993141653
  • Upwork Job ID: 1701832137355866112
  • Last Price Increase: 2023-09-13
  • Automatic offers:
    • aimane-chnaif | Reviewer | 26744505
    • akinwale | Contributor | 26744506

About this issue

  • Original URL
  • State: closed
  • Created 10 months ago
  • Comments: 37 (20 by maintainers)

Most upvoted comments

Both paid.

I am not sure. Question for @marcochavezf

I checked the isEmailPublicDomain implementation. Looks like any private email domain would work. I’ll have the videos up in a bit.