App: [HOLD for payment 2023-10-02] [$500] Chat - Flag as offensive page does not disappear when deleting the Message

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. From User A Send a message to User B.
  2. From User B, Go to reply in thread on the message sent from User A. > Then Click on Flag as Offensive button from the reaction menu.
  3. Now Delete the message from User A while the Flag as offensive page is still open from User B.

Expected Result:

The opened Flag as offensive page from User B. should be closed when User A deletes the message. It should show the Page Not Found error message.

Actual Result:

The Flag as offensive page remains open.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.66-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/82d93680-e12d-47c3-a59d-806cc80da380

https://github.com/Expensify/App/assets/115492554/93d87411-fd1d-47e4-b62f-b54655df9b8e

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692641567668079

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f9ee295f5f5cd370
  • Upwork Job ID: 1702099690396909568
  • Last Price Increase: 2023-09-13
  • Automatic offers:
    • 0xmiroslav | Reviewer | 26722920
    • tienifr | Contributor | 26722922
    • daveSeife | Reporter | 26722924

About this issue

  • Original URL
  • State: closed
  • Created 10 months ago
  • Comments: 32 (19 by maintainers)

Most upvoted comments

yep! show not found

yes please

This is kind of “dynamic update” issue and the bug always existed after flag implementation. As this is unusual case, I propose no regression test.

Payment Summary:

Upwork job

Hope this would be eligible for efficiency bonus as C+ approved PR in 2 days 15 hrs and there were no changes requested. cc: @srikarparsi

@dangrous - my assumption is that we’d want to be consistent across the board, so we’ll show page not found upon deletion of the offensive comment. Can I confirm this is what you’re thinking too? Thanks!