App: [HOLD for payment 2023-08-10] [$1000] Web - Select and copy does not copy New Expensify link in link format
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open the app
- Open any report
- Send normal link eg:
[test](google.com) - Select the text and copy
- Paste and see it has proper link format
- Send newdot link eg:
[test](staging.new.expensify.com/r/64705864)(note, the home link new.expensify.com does not reproduce this issue) - Select the text and copy, paste and observe that now text is only displayed without link
Expected Result:
App should copy all links equally on select and copy
Actual Result:
App does not copy expensify links as links and display their text normally
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.42-18 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/173c49bc-c56a-4856-a3c8-e3ef7fd98e8e
Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689704143206879
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~011c078f18bc8d09c6
- Upwork Job ID: 1683719949577637888 2023-07-25
- Automatic offers:
- dhanashree-sawant | Reporter | 25815614
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 49 (23 by maintainers)
Reviewed the details for @mananjadhav. This is approved for payment in NewDot.
Apologies for the delay in the response here. I see some of the comments edited, hence wanted to verify before I respond.
@samh-nl to address your comments, your proposal originally lacked any technical details. I don’t expect the code, but at-least where/how do we pass the hrefs, etc. should’ve been a part of the proposal. And we do work out changes in the PR, bugs that come across testing when the PR is raised.
About you mentioning the proposal being completely incorrect, if we come across this in the PR/issue, we would open up again for the proposals, where the new/existing proposals would be reviewed for the expected behavior. This generally doesn’t happen, but I won’t say it has never happened.
Lastly, @Parshvi16 I would recommend sticking to the original proposals while implementing the solution, so that we’re fair in any process without any conflicts.
@kadiealexander I’ve raised my request on NewDot.
Payouts due on August 10th:
Eligible for 50% #urgency bonus? Yes
Upwork job is here.
@mananjadhav Ok appreciate the feedback, I will take that into account going forward.
@Parshvi16 the job wasn’t assigned to you yet. Hence I’ll review the PR only after it is assigned. Please read our contributing guidelines to understand the process.
We are still waiting for a confirmation from an Expensify engineer.
Updated the reproduction steps with our findings.
All good, glad we got to the root of it! 😃
https://github.com/Expensify/App/assets/59587260/4c6d0d7a-33e3-4bd0-8dec-124358f70ee3