App: [HOLD for payment 2023-08-08] Dev: Web - Console log error when trying to unlink secondary contact method
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open a tab where account A is signed-in
- Add secondary contact method B, and do not verify that contact method
- Open a new window > Navigate to sign-in page
- Enter secondary contact method B & click on the continue button
Expected Result:
There shouldn’t be any console log error
Actual Result:
Console log error displayed (ailed prop type: The prop welcomeText is marked as required in SignInPageContent, but its value is undefined.)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: Dev 1.3.40-5 Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/39606f7d-96cd-4849-a4e4-ec06612db825
Expensify/Expensify Issue URL: Issue reported by: React JS Developer | Software QA Analyst | GH: @Natnael-guchima Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689337434182419
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 20 (12 by maintainers)
Reporting offer sent - only payment due here seeing as Monil took the fix internally 🙏
Commented on the PR. Looks like we missed this during Migration from class component to functional component, and is a minor change. Would just push a quick fix and request review from author.
Sorry, I’m able to reproduce the issue. Looking if it’s a regression, so we can ask author to fix it.