App: [HOLD for payment 2023-07-21] [$1000] Web - Heading after quote is not rendering

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go a chat and add a comment

> quote
# heading

Notice that heading is displayed in plain text

Expected Result:

Heading should be rendered

Actual Result:

Markdown heading syntax is not rendering

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: 1.3.32-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/8626f832-2e3e-4705-9f42-59b82d7d7172 https://github.com/Expensify/App/assets/93399543/7f95a2a1-6c96-4a48-afbe-712edae38043

Expensify/Expensify Issue URL: Issue reported by: @eh2077 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687921581684809

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e498007bd2f0de5b
Upwork Job ID: 1674345101139329024
Last Price Increase: 2023-07-06

About this issue

Original URL
State: closed
Created a year ago
Comments: 85 (69 by maintainers)

Most upvoted comments

@code0406 and @spcheema Thank you for your continuous work here. I think we can go with @spcheema’s proposal.

🎀 👀 🎀 C+ reviewed

s77rt on Jul 4, 2023

Thanks @conorpendergrast @cead22 and @s77rt

spcheema on Jul 26, 2023

Not overdue per @conorpendergrast 's update above

cead22 on Jul 26, 2023

The PR that introduced the bug has been identified: This existed since day one https://github.com/Expensify/expensify-common/pull/468
The offending PR has been commented on: https://github.com/Expensify/expensify-common/pull/468#discussion_r1264522145
A discussion in #expensify-bugs has been started: I don’t think this is needed here, the automatic tests should be enough to prevent such bugs.
Determine if we should create a regression test for this bug: No

s77rt on Jul 15, 2023

Thanks @cead22 and @s77rt.

I have updated the hash 0c685f8 and raise another PR for the APP

Here is the link https://github.com/Expensify/App/pull/22478

spcheema on Jul 11, 2023

@cead22 and I agree with an exception here as the C and C+ acted with urgency.

Everyone has been paid accordingly, and contracts ended. We’re all done, thanks!

conorpendergrast on Jul 26, 2023

I will check in on is one, and confirm before paying. I’m OoO on Monday and Tuesday, and will be back to this on Wednesday 26th with confirmation

conorpendergrast on Jul 21, 2023

@conorpendergrast @s77rt Please consider following timings for bonus eligibility:

Action	Timing
Issue assigned	2023-07-06T23:43:37Z
`E\Common` PR up for review	2023-07-08T05:31:21Z
C++ approved	2023-07-08T11:25:07Z
PR merged	2023-07-10T20:31:41Z
`E\APP` PR up for review	2023-07-10T22:12:45Z
C++ approved	2023-07-11T05:33:17Z
PR merged	2023-07-12T16:43:13Z

After C++ reviewed & approved, following timeline is waiting for internal reviewer to approve and merge the PR.

Waiting time for E\Common PR approval & merge: 2 days 9 hours 6 minutes 34 seconds
Waiting time for E\APP PR approval & merge: 1 days 11 hours 9 minutes 56 seconds

Total waiting time (internal & merge): 3 days 20hrs approx.

Total time elapsed from issue assigned to second PR merged: 5 days 16 hours 59 minutes 36 seconds

spcheema on Jul 22, 2023

@cead22 @s77rt PR is up for review Expensify/expensify-common#557

@spcheema this is merged now

cead22 on Jul 10, 2023

@cead22 @s77rt PR is up for review https://github.com/Expensify/expensify-common/pull/557

Kindly review it and then I’ll raise another one to update the expensify-common lib in the App

spcheema on Jul 8, 2023

📣 It’s been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] on Jul 6, 2023

@code0406 Thanks for the update. I think that solution is more complicated than it should be.

s77rt on Jul 1, 2023

@code0406 I think the alternative solution is suggested by @spcheema already. For now we are looking for better solutions

okay. I will share the better solution soon.

code0406 on Jun 30, 2023

@spcheema Oops we just inverted the bug 😅. I don’t think we should go with option 1 for now, it’s better to find a solution that does not involve making one rule aware of the other, let’s make that our last resort solution. Please update your proposal and tag me again.

s77rt on Jun 30, 2023