App: [HOLD for payment 2023-07-21] [$1000] Inconsistency - Link previews have different border color than quotes
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open the app.
- Send a quote message in any chat. ex -
> hello. - Send a link. ex -
google.comand wait for the link preview to appear. - Notice that the left border has a different color in both cases.
Expected Result:
Border color should be consistent for both link previews and quote.
Actual Result:
Border color is different for both link preview and quote.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.33-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/de42dbc7-a466-45f3-84a1-cf3b68ec1c43
Expensify/Expensify Issue URL: Issue reported by: ~@Nikhil-Vats~ Bortman Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687966486390789
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01034485de0b01882f
- Upwork Job ID: 1676724101797347328
- Last Price Increase: 2023-07-05
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 31 (14 by maintainers)
Preview link with quote message was missing test case while implementing new feature of link preview in https://github.com/Expensify/App/pull/17288. This was minor style inconsistency and I don’t think regression test step is needed.
@aimane-chnaif and @Nikhil-Vats paid $1500 each, inc. urgency bonus. Apologies for the delay, I was OOO a couple days. @aimane-chnaif , please fill out the checklist above. https://github.com/Expensify/App/issues/21882#issuecomment-1635953496
Thanks @Nikhil-Vats , I opened an internal GH to address the
-bug. Removed ya from the OP for bug reporter too.Thanks for the review @aimane-chnaif, assigning @Nikhil-Vats 🚀
@Nikhil-Vats’s proposal looks good. Straightforward fix. 🎀 👀 🎀 C+ reviewed
My proposal above.