App: [HOLD for payment 2023-06-29] [$1000] Tooltip not showing for single member in a group chat icon in LHN
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- look for a group in LHN
- hover over single person and then +4 or +n icon
Expected Result:
tooltips should be present for each
Actual Result:
Describe what actually happened
Workaround:
tooltip present only in +n icon and not in single member icon
ALSO:
Action Performed:
- go to settings-> worksapces
- select any workspace and go to invite members
- select invite -> choose few members -> next
- ON add message page, hover over avatar and notice there is profile tooltip
Expected Result:
tooltip with profile description
Actual Result:
no Tooltip is shown on add message page after memeber invitation
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: main
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686833052798899
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686832877081139
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0126747ee9e5114f69
- Upwork Job ID: 1669337684643139584
- Last Price Increase: 2023-06-15
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 58 (40 by maintainers)
Nice, thanks @0xmiroslav. Okay, given the size of the fix, I’m not included to say it’s worth… counts issues $8k, but I think we can add another $1k + bonus (so this would be $3k total = $2k + 50% bonus). I’ll pay out $250 for each of the reporters above.
Here’s summary of reporters per each issue: https://github.com/Expensify/App/issues/20801 - LHN display names - reported by @gadhiyamanan https://github.com/Expensify/App/issues/20813 - report header - reported by @huzaifa-99 https://github.com/Expensify/App/issues/20820 - invite members - reported by @ashimsharma10 https://github.com/Expensify/App/issues/20822, https://github.com/Expensify/App/issues/20934 - LHN group avatars - first reported by @chiragxarora https://github.com/Expensify/App/issues/20971 - Concierge icon (QA team) https://github.com/Expensify/App/issues/20981 - members list - reported by @tewodrosGirmaA
I think bug reporting bonus is eligible for 5 people above. cc: @twisterdotcom
@situchan if you’re free to work on this ASAP please do! I’ll assign you 👍
All paid out.
I don’t think regression test step is needed. The list of issues occurred during secure logins refactor.
🧇 I’m removing AlexM’s assignment. Seems this doesn’t need a new CME since we are just doing payment.
This fix was CP’d to staging
Thanks @situchan - sorry for the confusion, I just wasn’t sure if you’d be free quickly 😅
I think we should ask @situchan to work on it as they’ve commented on their availability and we can review this asap
I can work on this quickly
Ok looks like I overlooked the fact that
ROUTES.getProfileRouteaccepts an accountID, and I believe we have started to store accountIDs inoptionsso we should be able to still get rid ofReportUtils.getAccountIDForLogin(here 👍I also follow that. I commented on that PR.
As the root cause is same, I suggest to handle both in one issue.