App: [HOLD for payment 2023-06-29] [$1000] Dev: Android/iOS - Invalid prop console error

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open any chat

Expected Result:

No console error

Actual Result:

Console error appears (invalid props.style key cursor)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: 1.3.25-4 Reproducible in staging?: Dev Reproducible in production?: Dev If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL: Issue reported by: @bernhardoj Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686120988945439

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0151ecf2b81452ae95
Upwork Job ID: 1669423474662707200
Last Price Increase: 2023-06-15

About this issue

Original URL
State: closed
Created a year ago
Comments: 50 (35 by maintainers)

Most upvoted comments

Payment to rajat still on hold. Bumped in Slack.

joekaufmanexpensify on Jul 5, 2023

I am sure , that Help wanted got removed mistakenly.

parasharrajat on Jun 15, 2023

@stephanieelliott yes. You will see the warning box at the bottom when you open a chat (dev only I guess)

bernhardoj on Jun 15, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Android/iOS - Invalid prop console error

What is the root cause of that problem?

We’re using styles.cursorPointer for the Text inside ReportPreview. Screen Shot 2023-06-12 at 21 59 23

What changes do you think we should make in order to solve the problem?

Because we wanna keep the cursor when hovering the text, we can replace current usage of current Text with TextLink component like we already did here. Also add onPress to prevent it open url.

<TextLink 
   onPress={() => {Navigation.navigate(ROUTES.getReportRoute(props.iouReportID));}} 
   style={[styles.chatItemMessage, styles.colorMuted]}>
   {lodashGet(message, 'html', props.translate('iou.payerOwesAmount', {payer: managerName, amount: reportAmount}))}
</TextLink>

What alternative solutions did you explore? (Optional)

N/A

hungvu193 on Jun 12, 2023